problem_report: add get_on_disk_size() to CompressedFile#606
Open
bdrung wants to merge 1 commit into
Open
Conversation
`UserInterface.get_complete_size` and `UserInterface.get_reduced_size` need to determine the on-disk size of the problem report values. `CompressedFile` does not support `len()`. Add a `get_on_disk_size()` method to `CompressedFile`.
bdrung
force-pushed
the
compressed-file-get_reduced_size
branch
from
5070a09 to
f88764b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=======================================
Coverage 84.52% 84.53%
=======================================
Files 104 104
Lines 21000 21010 +10
Branches 3219 3220 +1
=======================================
+ Hits 17751 17761 +10
- Misses 2808 2809 +1
+ Partials 441 440 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UserInterface.get_complete_sizeandUserInterface.get_reduced_sizeneed to determine the on-disk size of the problem report values.CompressedFiledoes not supportlen().Add a
get_on_disk_size()method toCompressedFile.