report: use list comprehension to check for interpreters#608
Open
bdrung wants to merge 1 commit into
Open
Conversation
mypy will complain if `ProblemReport` will get type hints: ``` error: Argument 1 to "filter" has incompatible type "Callable[[Any], bool]"; expected "Callable[[str], TypeGuard[object]]" [arg-type] error: Value of type variable "AnyStr" of "fnmatch" cannot be "object" [type-var] ``` Use a list comprehension instead to make mypy happy and the code more readable.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
==========================================
- Coverage 84.52% 84.51% -0.01%
==========================================
Files 104 104
Lines 21000 21000
Branches 3219 3219
==========================================
- Hits 17751 17749 -2
- Misses 2808 2811 +3
+ Partials 441 440 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mypy will complain if
ProblemReportwill get type hints:Use a list comprehension instead to make mypy happy and the code more readable.