Skip to content

apport: get value for CoreDump only once#612

Merged
bdrung merged 1 commit into
canonical:mainfrom
bdrung:coredump-variable
May 7, 2026
Merged

apport: get value for CoreDump only once#612
bdrung merged 1 commit into
canonical:mainfrom
bdrung:coredump-variable

Conversation

@bdrung
Copy link
Copy Markdown
Member

@bdrung bdrung commented Apr 28, 2026

Ease mypy to determine the type of the problem report value for CoreDump by getting the value only once and store it in a variable.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.56%. Comparing base (1e03e7c) to head (8593aa3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #612   +/-   ##
=======================================
  Coverage   84.56%   84.56%           
=======================================
  Files         104      104           
  Lines       21028    21029    +1     
  Branches     3219     3219           
=======================================
+ Hits        17782    17783    +1     
+ Misses       2805     2804    -1     
- Partials      441      442    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Ease mypy to determine the type of the problem report value for
`CoreDump` by getting the value only once and store it in a variable.
@bdrung bdrung force-pushed the coredump-variable branch from 7434aae to 8593aa3 Compare May 7, 2026 08:12
@bdrung
Copy link
Copy Markdown
Member Author

bdrung commented May 7, 2026

Just rebased.

@bdrung bdrung merged commit 8593aa3 into canonical:main May 7, 2026
19 checks passed
@bdrung bdrung deleted the coredump-variable branch May 7, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants