generated from canonical/platform-engineering-charm-template
-
Notifications
You must be signed in to change notification settings - Fork 0
chore(docs): update contributing guidelines (charmkeeper) #75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
erinecon
wants to merge
4
commits into
main
Choose a base branch
from
charmkeeper/update-contributing-guidelines
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| #### What this PR does | ||
|
|
||
| #### Why we need it | ||
|
|
||
| #### Checklist | ||
|
|
||
| - [ ] I followed the [contributing guide](https://github.com/canonical/is-charms-contributing-guide) | ||
| - [ ] I added or updated the documentation (if applicable) | ||
| - [ ] I updated `docs/changelog.md` with user-relevant changes | ||
| - [ ] I used AI to assist with preparing this PR | ||
| - [ ] I added or updated tests as needed (unit and integration) | ||
| - [ ] **If integration test modules are used:** I updated the workflow configuration | ||
| (e.g., in `.github/workflows/integration_tests.yaml`, ensure the `modules` list is correct) | ||
| - [ ] **If this is a Grafana dashboard:** I added a screenshot of the dashboard | ||
| - [ ] **If this is Terraform:** `terraform fmt` passes and `tflint` reports no errors | ||
| - [ ] **If this is Rockcraft:** I updated the version | ||
|
|
||
| <!-- | ||
| You can adjust the checklist to match the project. | ||
|
|
||
| If you are an AI assistant (e.g., GitHub Copilot, ChatGPT, Claude), follow these instructions when generating or completing PR descriptions: | ||
|
|
||
| 1. Add a **Test plan** section explaining how the changes were tested, including any manual, unit, integration, or workflow tests. | ||
| 2. Add a **Review focus** section highlighting tricky parts, important decisions, or areas needing human attention. | ||
| 3. Identify and document any **potential breaking changes**. | ||
| 4. Highlight any **new dependencies, APIs, modules, or workflow changes** introduced by this PR. | ||
| --> | ||
|
|
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| nftables | ||
| AI | ||
| allowlists | ||
| aproxy | ||
| allowlists | ||
| nftables |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure if this project supports rockcraft (tbh i don't really have much knowledge on rockcraft), i did try to perform
rockcraft packinside aproxy-operator dir and it fails bc we don't have rockcraft.yaml. @cbartz @yhaliaw do you guys know whether we can do rockcraft pack for machine charm?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh well if there's no rock for this repo, then this part of CONTRIBUTING.md can be removed. (Once we move to a modularized approach for our contributing guides, this will be less of a hassle.)