Skip to content

Enable proxy_cache_revalidate by default#28

Draft
yhaliaw wants to merge 2 commits intomainfrom
feat/proxy-cache-revalidate
Draft

Enable proxy_cache_revalidate by default#28
yhaliaw wants to merge 2 commits intomainfrom
feat/proxy-cache-revalidate

Conversation

@yhaliaw
Copy link
Copy Markdown
Contributor

@yhaliaw yhaliaw commented Jan 10, 2025

Overview

Enable proxy-cache-revalidate by default.

Rationale

This was requested for the k8s content-cache and makes sense for the this charm as well.

Checklist

  • The charm style guide was applied
  • The contributing guide was applied
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation is generated using src-docs
  • The documentation for charmhub is updated
  • The PR is tagged with appropriate label (urgent, trivial, complex)
  • The docs/changelog.md is updated with user-relevant changes.

@github-actions
Copy link
Copy Markdown
Contributor

Test coverage for f9998c9

Name            Stmts   Miss Branch BrPart  Cover   Missing
-----------------------------------------------------------
src/charm.py       47      0      6      0   100%
src/errors.py       1      0      0      0   100%
src/state.py      115      0     28      0   100%
-----------------------------------------------------------
TOTAL             163      0     34      0   100%

Static code analysis report

Run started:2025-01-10 11:14:11.555662

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 938
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant