Conversation
3868c21 to
c24cbcd
Compare
288cd59 to
4559641
Compare
49100f1 to
c4f1084
Compare
c4f1084 to
a4e8956
Compare
Meulengracht
left a comment
There was a problem hiding this comment.
Thanks! I added a suggestion for the future in how to handle running tests with different variables, but I don't require you to change anything here.
|
|
||
| tests-main: | ||
| runs-on: self-hosted | ||
| tests-main-stable: |
There was a problem hiding this comment.
Thanks for doing this! Looks nice, alternative idea for future times, is that you could use a test-matrix instead of defining identical targets where only a variable is changing:
See examples:
https://github.com/snapcore/core-testing-jobs/blob/main/.github/workflows/cdimage-nightly.yml
So you could do like this:
strategy:
fail-fast: false
matrix:
channel: [stable, edge]
with:
snapd_branch: ${{ matrix.channel }}
Even better, maybe you could even define the templates as as matrix variable, but I'm not sure that github would accept that, as I don't know the order of evaluation when the workflow is passed (it was a hell with azure actions).
strategy:
fail-fast: false
matrix:
workflow: [tests-main.yml, tests-snapd.yml]
channel: [stable, edge]
uses: ./.github/workflows/${{ matrix.workflow }}
with:
snapd_branch: ${{ matrix.channel }}
There was a problem hiding this comment.
That works, yes. We should do that in another PR. I am not totally yet convince we require a matrix here.
|
This needs rebasing |
a4e8956 to
9e334af
Compare
Otherwise we might end up merging things that depend on fixes of snapd that are not released.
9e334af to
4eb9bbc
Compare
Otherwise we might end up merging things that depend on fixes of snapd that are not released.