tests: workaround - make the first test to run in snap testing to be a universal test#190
Open
artiepoole wants to merge 1 commit into
Open
tests: workaround - make the first test to run in snap testing to be a universal test#190artiepoole wants to merge 1 commit into
artiepoole wants to merge 1 commit into
Conversation
artiepoole
force-pushed
the
artie/test-order-hotfix
branch
from
dbd264e to
74b6245
Compare
…a universal test Just renames test_status_with_device_option to test_status_with_specific_device_option. This is works since tests are discovered alphabetically. This is necessary because the dfx-mgr test being first means that the attempt to call dfx-mgr-client happens before dfx-mgrd is up and running. There should be a proper way to wait for come-up in dfx-mgr softener This test name must be alphabetically after the universal test to ensure that the first test doesn't require dfx-mgr to be up and running which takes a few ms. Signed-off-by: Artie Poole <stuart.poole@canonical.com>
artiepoole
force-pushed
the
artie/test-order-hotfix
branch
from
74b6245 to
05103b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
workaround for #189 which just (hopefully) makes the tests more stable <- this needs to be fixed robustly.
Just renames test_status_with_device_option to test_status_with_specific_device_option.
This is works since tests are discovered alphabetically. This is necessary because the dfx-mgr test being first means that the attempt to call dfx-mgr-client happens before dfx-mgrd is up and running. There should be a proper way to wait for come-up in dfx-mgr softener
This test name must be alphabetically after the universal test to ensure that the first test doesn't require dfx-mgr to be up and running which takes a few ms.