Merged
Conversation
* chore(deps): update dependency openstacksdk to v4.9.0 * lint * fix bandit warnings * lint app * fix bandit in app * fix(tests): revert integration test secrets to hardcoded values with nosec The integration test commands.py greps for specific strings (SHOULD_EXIST, SHOULD_NOT_EXIST) to verify secret handling. Random tokens broke these checks. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix(build): resolve PyYAML/Cython source build failure Pin wheel>=0.45 to fix incompatibility with setuptools 80.x in charmcraft's isolated build environments. Add build packages (cython3, libyaml-dev, python3-dev) needed for PyYAML source compilation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
Co-authored-by: Christopher Bartz <christopher.bartz@canonical.com>
swetha1654
requested review from
cbartz,
javierdelapuente,
yanksyoon and
yhaliaw
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the integration-test setup to support the proxy-related upgrade path that failed after #185, by moving test-charm packing and additional host/network preparation into the CI workflow pre-run phase.
Changes:
- Add a CI pre-run script to pack the integration test charm and adjust nftables/aproxy handling.
- Update integration test fixtures to apply additional model proxy configuration and stop building the test charm in-Python.
- Add a changelog entry for the integration test update.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
tests/integration/pre_run_script.sh |
New pre-run script to pack the test charm and insert an nftables rule. |
tests/integration/conftest.py |
Adjust model proxy config and remove the in-test charmcraft packing step. |
docs/changelog.md |
Record the integration test update in the changelog. |
.github/workflows/integration_test.yaml |
Wire the new pre-run script into the reusable integration-test workflow inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cbartz
approved these changes
Feb 18, 2026
Collaborator
cbartz
left a comment
cbartz
left a comment
There was a problem hiding this comment.
LGTM. One minor comment.
javierdelapuente
approved these changes
Feb 18, 2026
Collaborator
javierdelapuente
left a comment
javierdelapuente
left a comment
There was a problem hiding this comment.
Looks good to me after tackling the current comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
This PR updates integration tests that were intentionally not done in #185.
Rationale
In #185, I updated the self-hosted runner to stop using aproxy through the pre-run-script. While
test_charmpassed, test_upgrade failed before the upgrade step. The failure occurred because the test attempted to install an older version of the image builder, and that earlier charm revision did not support passing proxy values to the workload. As a result, the install hook failed.Fixing the integration tests within the same PR would have required significant additional work and did not align with the intended scope. The upgrade scenario exercised there is not a valid use case in ps7, as we currently do not have a working image builder in that environment.
Therefore, this follow-up PR introduces the integration tests after ensuring that the previous image builder revision includes built-in proxy support in the charm. This allows the upgrade path to function correctly and keeps the changes scoped and reviewable.
Juju Events Changes
Module Changes
Library Changes
Checklist
urgent,trivial,senior-review-required,documentation)app/pyproject.toml