Conversation
yhaliaw
commented
Mar 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Ubuntu 26.04 (“resolute”) as a supported base image across the charm configuration, image-builder package, and CI/integration coverage so the project can build and validate 26.04 runner images.
Changes:
- Extend base-image/version mappings and enums to include
26.04/resolute. - Update image initialization/upload paths and test expectations to cover
resolute. - Adjust integration tests/commands and CI matrix to run (and selectively skip) checks on 26.04.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/state.py |
Adds 26.04 -> resolute mapping for charm-side image selection. |
charmcraft.yaml |
Updates config description to mention resolute as supported. |
app/src/github_runner_image_builder/config.py |
Adds BaseImage.RESOLUTE and version/tag mapping for 26.04. |
app/src/github_runner_image_builder/openstack_builder.py |
Downloads/uploads resolute base image; adjusts external-script sudo logging behavior for 26.04; passes base image into script runner. |
app/src/github_runner_image_builder/templates/cloud-init.sh.j2 |
Skips HWE kernel install on resolute; adds note about bbr on 26.04. |
app/tests/unit/test_config.py |
Adds unit coverage for BaseImage.RESOLUTE parsing/mapping. |
app/tests/unit/test_openstack_builder.py |
Updates expected cloud-init script content to match resolute-specific behavior. |
app/tests/integration/helpers.py |
Updates external script URL pin; adds resolute -> 26.04 mapping for integration metadata. |
app/tests/integration/testdata/test_script.sh |
Updates how secrets are preserved/passed in the external test script. |
app/tests/integration/test_openstack_builder.py |
Renames/adjusts secret keys used by the integration script/secrets checks. |
app/tests/integration/commands.py |
Skips HWE/bbr/journal URL checks on 26.04; updates secret assertions. |
.github/workflows/integration_test_app.yaml |
Adds resolute to the integration test matrix (amd64 only via excludes). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Add support for building ubuntu 26.04 images.
Rationale
Needed for the new LTS ubuntu.
Module Changes
Checklist
urgent,trivial,senior-review-required,documentation)app/pyproject.toml