Skip to content

fix(proxy): proxy env setup #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yanksyoon wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

fix(proxy): proxy env setup #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bbc423
fix: proxy env setup
yanksyoon Mar 24, 2026
405fa53
docs: changelog
yanksyoon Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

[project]
name = "github-runner-image-builder"
version = "0.13.0"
version = "0.13.1"
Copy link
Copy Markdown
Contributor

@swetha1654 swetha1654 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump up the version if there are no changes in the image-builder app?

authors = [
{ name = "Canonical IS DevOps", email = "is-devops-team@canonical.com" },
]
Expand Down
3 changes: 3 additions & 0 deletions docs/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@

<!-- vale Canonical.007-Headings-sentence-case = NO -->

## [#213 Fix proxy setup]
* Fix proxy setup for image-relation joined hook.

## [#206 Add resolute image support]
* Add resolute image support.

Expand Down
1 change: 1 addition & 0 deletions src/image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def _on_image_relation_joined(self, event: ops.RelationJoinedEvent) -> None:
event: The event emitted when a relation is joined.
"""
build_config = state.BuilderConfig.from_charm(charm=self.charm)
self.charm._setup_proxy_environment(build_config.proxy)
proxy = state.ProxyConfig.from_env()
if not build_config.cloud_config.upload_cloud_ids:
self.model.unit.status = ops.BlockedStatus(
Expand Down
Loading