Separates the storage directives for different worker roles#182
Merged
Separates the storage directives for different worker roles#182
Conversation
Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com>
Contributor
|
This makes sense to me. Do not worry about the itests failing, we are resolving those in an upcoming pulse. This implementation somewhat collides with the idea of COS product flavors. E.g. We still need:
|
MichaelThamm
reviewed
Feb 9, 2026
Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com>
Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com>
Contributor
|
Now that you have tested the PR, using the temporary refs for: Loki, Mimir, Tempo you will have to:
|
MichaelThamm
approved these changes
Feb 11, 2026
Signed-off-by: Bartlomiej Gmerek <bartlomiej.gmerek@canonical.com>
Contributor
Author
|
@MichaelThamm All merged and cleaned up. Please take one last look, just in case ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #183
Solution
Checklist
Context
Testing Instructions
Upgrade Notes