feat: explicitly pass secrets in charm-release.yaml#355
Open
Guillaumebeuzeboc wants to merge 2 commits intocanonical:v0from
Open
feat: explicitly pass secrets in charm-release.yaml#355Guillaumebeuzeboc wants to merge 2 commits intocanonical:v0from
Guillaumebeuzeboc wants to merge 2 commits intocanonical:v0from
Conversation
`secrets: inherit`, does not work when the workflow is called from an outside organization. Signed-off-by: Guillaume Beuzeboc <guillaume.beuzeboc@gmail.com>
lucabello
changed the title
Contributor
|
Hey Guillaume, thanks for the PR :) I want to run a few tests with the o11y-tester charm before merging, but this looks good! |
Contributor
|
Hi @lucabello , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces some automatic inheritance of all secrets in github workflow by explicitly
passing the one secret that's required.
Beside security consideration,
secrets: inherit,does not work when the workflow is called from another organization.
This seriously limits the reusability of the workflow.
Github doc: (link)
For instance, in our project: foxglove-k8s-operator, the workflow was evaluating the
CHARMCRAFT_TOKENto an empty string due to this limitation ofsecrets: inheritin the charm-release.yaml workflow.This patch has been tested here: https://github.com/ubuntu-robotics/foxglove-k8s-operator/actions/runs/15927819021/job/44929252521
Mind that the patch doesn't break any existing workflow,
but it may require in the future to maintain the list of secrets that are supposed to be passed.