feat: display juju debug-log in integration test runs#360
Open
PietroPasotti wants to merge 25 commits intomainfrom
Open
feat: display juju debug-log in integration test runs#360PietroPasotti wants to merge 25 commits intomainfrom
PietroPasotti wants to merge 25 commits intomainfrom
Conversation
lucabello
requested changes
Jul 10, 2025
Contributor
lucabello
left a comment
There was a problem hiding this comment.
To re-review this PR, I would like:
- convert the PR title to conventional commits format, like we practice everywhere
- test the branch with some repository (if you don't know which one, use https://github.com/canonical/o11y-tester-operator) and link a successful run here
- consider updating the diagram here and see how it looks like (adding another box under integration tests maybe)?
Contributor
Author
|
@lucabello ready for another round, all points addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change to
_charm-quality-checks.yaml(integration tests part) adding two steps:for each file found in
./.logs:the idea is, we can put our juju debug-log output in there, and the CI will display them and upload as artifact.
Context: https://github.com/canonical/pytest-jubilant/pull/11
Tandem PR to demonstrate the workflow in action: https://github.com/canonical/o11y-tester-operator/actions/runs/16414197049