Skip to content

Comments

feat: display juju debug-log in integration test runs#360

Open
PietroPasotti wants to merge 25 commits intomainfrom
feat/jdl-upload
Open

feat: display juju debug-log in integration test runs#360
PietroPasotti wants to merge 25 commits intomainfrom
feat/jdl-upload

Conversation

@PietroPasotti
Copy link
Contributor

@PietroPasotti PietroPasotti commented Jul 7, 2025

Change to _charm-quality-checks.yaml (integration tests part) adding two steps:

for each file found in ./.logs:

  1. print to console
  2. upload it as artifact

the idea is, we can put our juju debug-log output in there, and the CI will display them and upload as artifact.

Context: https://github.com/canonical/pytest-jubilant/pull/11

Tandem PR to demonstrate the workflow in action: https://github.com/canonical/o11y-tester-operator/actions/runs/16414197049

@PietroPasotti PietroPasotti requested a review from a team as a code owner July 7, 2025 11:54
Copy link
Contributor

@lucabello lucabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To re-review this PR, I would like:

  • convert the PR title to conventional commits format, like we practice everywhere
  • test the branch with some repository (if you don't know which one, use https://github.com/canonical/o11y-tester-operator) and link a successful run here
  • consider updating the diagram here and see how it looks like (adding another box under integration tests maybe)?

@PietroPasotti PietroPasotti changed the title Display juju debug-log in integration test runs feat: display juju debug-log in integration test runs Jul 11, 2025
@PietroPasotti
Copy link
Contributor Author

@lucabello ready for another round, all points addressed

@PietroPasotti PietroPasotti requested a review from lucabello July 23, 2025 08:28
@PietroPasotti PietroPasotti changed the title feat: display juju debug-log in integration test runs [feat]: display juju debug-log in integration test runs Jul 23, 2025
@PietroPasotti PietroPasotti changed the title [feat]: display juju debug-log in integration test runs feat: display juju debug-log in integration test runs Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants