Draft
Conversation
1 task
feat: Add lint TF endpoints to CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes canonical/observability-stack#39
Sample implementation:
TODO:
_charm-quality-checks.yamland_charm_-terraform.yamlWarning
If merged, this will make its way into the
v2track tag, meaning that all charms repo PRs which have.tffile changes will need to conform to the Terraform CI standard. This includes having:justfile.tfdocs-config.ymlWithout this, PRs will need to be merged on failing TF CI, which is not blocking.
This PR also introduces a linting check which ensures that the
endpointsin theoutputs.tffile is up-to-date with thecharmcraft.yaml. E.g. In the alertmanager-k8s repo you can see we are already diverging: