Conversation
sinapah
commented
Jan 14, 2026
MichaelThamm
approved these changes
Jan 15, 2026
Contributor
MichaelThamm
left a comment
There was a problem hiding this comment.
I reviewed your o11y-stack PR and it looks identical, therefore LGTM.
sinapah
commented
Jan 15, 2026
sinapah
commented
Jan 15, 2026
sinapah
commented
Jan 15, 2026
sinapah
commented
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines elements from #405 and adds a workflow input that a caller (from the Otelcol or GA charms) can set to indicate whether the charm release workflow should use local build or remote build. Most observability charm won't need to rely on remote build if they only need to be released for ARM and AMD. For Grafana Agent and Otelcol, we should rely on remote build since they need to also be released for S390x and PPC64EL.
Changes
pack-using-remote-buildinput tocharm-releaseand_charm-releasethat is false by default.pack-using-remote-buildwhen callingcharm-release. The value is propagated to_charm-release_charm-releaseWF is adjusted so ifpack-using-remote-buildis false, it locally packs the charm, similar to what it had done before. Otherwise, it remote builds it.Testing
PR canonical/o11y-tester-operator#35 in the tester repo tests this workflow. It can test both scenraios (remote vs local build) by setting the
pack-using-remote-buildparameter when calling thecharm-releaseworkflow. When set to false, this workflow uses the AMD and ARM runners to release in parallel. Otherwise, it executes remote-build from the AMD runner.