Make wrap_snap_operations return the actual error.#171
Make wrap_snap_operations return the actual error.#171crypticC0der wants to merge 1 commit intocanonical:mainfrom
Conversation
8a06744 to
38a0e34
Compare
Currently wrap_snap_operations just returns minimal error messages including only the names of the snaps that failed and not why. This is not particularly useful so I've expanded this to return include the actual error as well. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
|
Hi @crypticC0der, note that the Charmhub-hosted version of this library is deprecated by the charmlibs version. The version of the library in the charmlibs monorepo is identical right now, so your change would apply there. It's funny timing though, as I'm right in the middle of rewriting the library entirely -- and it will be completely dropping this unhelpful wrapping. Is this an improvement you're hoping to see in charms as soon as possible, or would waiting for the rewrite work? |
I'm raising this just as I'm making the change locally in canonical/microovn-operator#55 and i thought I'd pass along the update if you found it useful. I am in no real rush for the change to take place but please let me know when the rewrite is done with the new charm lib and I'll try move our products over |
|
Thanks for explaining the context. Patching your vendored copy of the lib like you're doing will no doubt be the fastest way to get this functionality in your charm. I'll be sure to let you know when the new library version is ready. I didn't have If you'd like to switch to the currently supported |
Currently wrap_snap_operations just returns minimal error messages including only the names of the snaps that failed and not why. This is not particularly useful so I've expanded this to return include the actual error as well.