Expose the TPM error when the public part of the elliptic key is invalid *debug only PR*#146
Draft
chrisccoulson wants to merge 2 commits intocanonical:masterfrom
Draft
Expose the TPM error when the public part of the elliptic key is invalid *debug only PR*#146chrisccoulson wants to merge 2 commits intocanonical:masterfrom
chrisccoulson wants to merge 2 commits intocanonical:masterfrom
Conversation
Collaborator
Author
Collaborator
Author
|
Huh, this is an obviously intermittent test failure that by some act of magic has never failed before. I think the issue is that go's big.Int truncates numbers to the minimum number of bytes required to hold the number, but the TPM requires key sizes to match the size specified by their configuration - so in the case of an elliptic key using the NIST P-256 curve, the public points must be 32 bytes. This means that keys generated by go's crypto/ecdsa package must be zero-extended to 32 bytes before loading them in to the TPM, something which this test isn't doing and I suspect is the reason for the test failures in #144 and #145 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a test failure in travis which isn't reproducible locally