AuthRequestor: Have snap-bootstrap return full messages rather than format strings#498
Merged
chrisccoulson merged 2 commits intocanonical:masterfrom Feb 2, 2026
Conversation
…ormat strings This makes it so that snap-bootstrap will return full messages rather than format strings for RequestUserCredential. This makes it consistent with how the next PR which adds the ability to send auth failure messages to Plymouth.
chrisccoulson
force-pushed
the
auth-requestor-update-string-callbacks
branch
from
49d1034 to
9008f4e
Compare
valentindavid
approved these changes
Feb 2, 2026
pedronis
reviewed
Feb 2, 2026
auth_requestor_plymouth.go
Outdated
| // - %[1]s: A human readable name for the storage container. | ||
| // - %[2]s: The path of the encrypted storage container. | ||
| RequestUserCredentialFormatString(authTypes UserAuthType) (string, error) | ||
| // RequestUserCredentialString returns messages used by RequestUserCredential. |
Collaborator
There was a problem hiding this comment.
this should probably described quickly what is name and what is path
Collaborator
Author
There was a problem hiding this comment.
I've updated this now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it so that snap-bootstrap will return full messages rather
than format strings for RequestUserCredential. This makes it consistent
with how the next PR which adds the ability to send auth failure
messages to Plymouth.