Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions snap_http/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
switch_all,
unhold,
unhold_all,
logs,
list,
list_all,
get_conf,
Expand Down
1 change: 1 addition & 0 deletions snap_http/api/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
switch_all,
unhold,
unhold_all,
logs,
)
from .snapshots import forget_snapshot, save_snapshot, snapshots
from .systems import (
Expand Down
12 changes: 12 additions & 0 deletions snap_http/api/snaps.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,3 +261,15 @@ def list_all() -> SnapdResponse:
"""GETs a list of all installed snaps including disabled ones.
"""
return http.get("/snaps?select=all")


def logs(names: List[str], entries: int = 10) -> SnapdResponse:
"""GETs snap logs
"""
query_params: Dict[str, Union[str, int]] = {
}

if names is not None:
query_params["names"] = ",".join(names)
query_params["n"] = entries
return http.get("/logs", query_params=query_params)
29 changes: 29 additions & 0 deletions tests/unit/api/test_snaps.py
Original file line number Diff line number Diff line change
Expand Up @@ -926,3 +926,32 @@ def mock_get(path):
result = api.list_all()

assert result == mock_response

@pytest.mark.parametrize(
("names", "entries", "expected_params"),
[
(None, 10, {"n":10}),
(["snapd", "core24"], 10, {"names": "snapd,core24", "n": 10}),
(["snapd", "core24"], 100, {"names": "snapd,core24", "n": 100}),
]
)
def test_logs(monkeypatch, names, entries, expected_params):
"""`api.logs` returns a `types.SnapdResponse`."""
mock_response = types.SnapdResponse(
type="sync",
status_code=200,
status="OK",
result=[{"title": "placeholder1"}, {"title": "placeholder2"}],
)

def mock_get(path, query_params):
assert path == "/logs"
assert query_params == expected_params

return mock_response

monkeypatch.setattr(http, "get", mock_get)

result = api.logs(names, entries)

assert result == mock_response