Skip to content

Replace Sh shell in shebang with Bash#209

Merged
nicolasbock merged 1 commit intocanonical:mainfrom
wilkmar:shell-fix
Sep 5, 2024
Merged

Replace Sh shell in shebang with Bash#209
nicolasbock merged 1 commit intocanonical:mainfrom
wilkmar:shell-fix

Conversation

@wilkmar
Copy link
Collaborator

@wilkmar wilkmar commented Jul 26, 2024

These two scripts still used Sh shell in shebang. In some situations, it was an issue when they sourced Bash specific scripts (directly or indirectly)

See PR #208 for details

Signed-off-by: Marcin Wilk <marcin.wilk@canonical.com>
Copy link
Member

@pponnuvel pponnuvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasbock nicolasbock merged commit a30b681 into canonical:main Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants