Skip to content

fix: Fix Swagger UI rendering of CVSS4 nested schema fields#273

Open
mtruj013 wants to merge 2 commits into
mainfrom
csv4-docs
Open

fix: Fix Swagger UI rendering of CVSS4 nested schema fields#273
mtruj013 wants to merge 2 commits into
mainfrom
csv4-docs

Conversation

@mtruj013

@mtruj013 mtruj013 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Done

  • Fixed cvs4 fields not showing up on swagger docs

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-37123

Screenshots

Screenshot 2026-06-11 at 15 19 17

@Skazitron

Skazitron commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@mtruj013 Thanks for the fix. Is there a way to achieve the same outcome without making those CVSS4 fields mandatory?

@mtruj013

Copy link
Copy Markdown
Contributor Author

@Skazitron removing allow_none=true doesn't make the fields mandatory, that's done with the required parameter. allow_none only controls whether an explicit null is valid, it defaults to false, meaning null would now be rejected if passed. I confirmed with the sec team that they do not pass these as null but rather just omit them so this parameter is not needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants