[DPE-9326]: Add HA Failover tests#28
Open
skourta wants to merge 15 commits intodpe-9325-network-hafrom
Open
Conversation
reneradoi
reviewed
Mar 24, 2026
Contributor
reneradoi
left a comment
There was a problem hiding this comment.
Just a few minor comments, looks good!
| environment: | ||
| TEST_MODULE: ha/test_failover.py | ||
| execute: | | ||
| tox run -e integration -- "tests/integration/$TEST_MODULE" --substrate k8s --alluredir="$SPREAD_TASK/allure-results" |
Contributor
There was a problem hiding this comment.
I think we need to parameterize these tests, otherwise they will just be deployed with tls=off and the other test will be skipped.
Contributor
Author
There was a problem hiding this comment.
That is a question I wanted to bring up in our 1-1. Should I also add TLS variants to all of these. Currently we do not.
Contributor
There was a problem hiding this comment.
As discussed: If not too much of hassle we can add the TLS run, yes. If it takes too long or is too much work for now, we can also postpone this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a coordinated restart lock mechanism for workload restarts, ensures safe handling of IP/hostname changes (especially on VMs), and improves certificate SAN handling for TLS. It also adds new status reporting for unhealthy restarts and refines lock management for start and restart operations. The changes are grouped below by theme.
Restart Lock and Event Handling:
RestartLockclass (subclassingDataBagLock) to coordinate restarts across units, with associated model fields (restart_member,request_restart_lock) and lock logic. This prevents concurrent restarts and ensures safe rolling restarts. [1] [2] [3]RestartWorkloadEventand corresponding event source/handler inBaseEvents, which triggers coordinated restarts of Valkey and Sentinel services, checks health post-restart, and sets or clears new unhealthy restart statuses. [1] [2] [3] [4] [5]TLS Certificate and IP/Hostname Change Handling:
get_current_sansandcertificate_sans_require_updatein the TLS manager. [1] [2]config_changedin TLS event handler for this purpose.Lock Management Improvements:
DataBagLockandStartLocklogic: added dynamic timestamp attribute, improved lock selection, and clarified lock-free checks for both start and restart operations. [1] [2] [3] [4] [5]Status and Configuration Reporting:
VALKEY_UNHEALTHY_RESTART,SENTINEL_UNHEALTHY_RESTART).Dependency Update:
kubernetesas a dependency inpyproject.toml.