Implement new RadioSelector design (issue #2655)#6397
Conversation
| }, | ||
| inputProps: { | ||
| 'data-testid': `${id}-field`, | ||
| readOnly: true, |
There was a problem hiding this comment.
I have a hunch that making it readOnly might cause problems in the integration test suite, but let's see the CI
There was a problem hiding this comment.
@timpel-fcs, please take a look at fe integration test results, we are getting
Cause: org.openqa.selenium.InvalidElementStateException: Element is read-only: <input id="offboard-sv-effective-date-field" class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedEnd css-5bywiu-MuiInputBase-input-MuiOutlinedInput-input" type="text">
There was a problem hiding this comment.
I made it readOnly to prevent format issues but can remove this
Regarding the font differences, yes the RadioSelector component is following the Figma here while the changes of the other components are not included, this will come in another PR for better scoping
There was a problem hiding this comment.
I made it readOnly to prevent format issues but can remove this
What issues? In general I'm fine with leaving the readOnly but then we'd need to find another way of setDateTime in the integration tests
There was a problem hiding this comment.
it was mostly to prevent accidental typing of wrongly formatted dates, I added on-click open of the calendar for date and time selection to prefer this over user input so I thought this was the best approach.
In the end it does not matter much, the tradeoff of removing is minimal since the date field will still open on click and even if there is incorrect input this will be handled by the validations
There was a problem hiding this comment.
Yeah, I see, I'd argue it's fine to make it r/w
|
1 more rebase to the fresh main please 🙏 |
Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
…e integration tests Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
|
adjusted the date picker in line with findings in #6407 |





Summary
Fixes #2655
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines