Skip to content

Implement new RadioSelector design (issue #2655)#6397

Open
timpel-fcs wants to merge 4 commits into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/2655
Open

Implement new RadioSelector design (issue #2655)#6397
timpel-fcs wants to merge 4 commits into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/2655

Conversation

@timpel-fcs

Copy link
Copy Markdown
Contributor

Summary

  • Add RadioSelector (presentational radio group with optional per-option extension slot and Figma-aligned custom icons).
  • Refactor EffectiveDateField to use it for Date vs Make effective at threshold, with restyled date picker (#363636 surface, YY-MM-DD HH:mm display).
  • Remove stale Effective At copy overrides from OffboardSvForm.

Fixes #2655

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@timpel-fcs

Copy link
Copy Markdown
Contributor Author

@pawelperek-da

Screenshot 2026-07-13 at 15 18 47 Screenshot 2026-07-13 at 15 18 53 Screenshot 2026-07-13 at 15 18 59

@timpel-fcs

Copy link
Copy Markdown
Contributor Author

Fixed missing padding from chevron, reverted changes to the dateField for new date format as per design as this will be tackled in the textInput issue globally to avoid conflicts and prevent test failures

Screenshot 2026-07-14 at 14 15 53

@pawelperek-da

Copy link
Copy Markdown
Contributor

The fonts seems smaller than in the rest of the system:
image

I'm assuming that's due to Figma conformance? Will the rest of elements also get similar treatment?

},
inputProps: {
'data-testid': `${id}-field`,
readOnly: true,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a hunch that making it readOnly might cause problems in the integration test suite, but let's see the CI

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timpel-fcs, please take a look at fe integration test results, we are getting

Cause: org.openqa.selenium.InvalidElementStateException: Element is read-only: <input id="offboard-sv-effective-date-field" class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputAdornedEnd css-5bywiu-MuiInputBase-input-MuiOutlinedInput-input" type="text">

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it readOnly to prevent format issues but can remove this

Regarding the font differences, yes the RadioSelector component is following the Figma here while the changes of the other components are not included, this will come in another PR for better scoping

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it readOnly to prevent format issues but can remove this

What issues? In general I'm fine with leaving the readOnly but then we'd need to find another way of setDateTime in the integration tests

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was mostly to prevent accidental typing of wrongly formatted dates, I added on-click open of the calendar for date and time selection to prefer this over user input so I thought this was the best approach.

In the end it does not matter much, the tradeoff of removing is minimal since the date field will still open on click and even if there is incorrect input this will be handled by the validations

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I see, I'd argue it's fine to make it r/w

@pawelperek-da

Copy link
Copy Markdown
Contributor

1 more rebase to the fresh main please 🙏

Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
…e integration tests

Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
@timpel-fcs

Copy link
Copy Markdown
Contributor Author

adjusted the date picker in line with findings in #6407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SV UI Redesign Look & Feel: Component: RadioSelector

6 participants