Address flakiness and latency in the Traffic-Based App Rewards integration test#6440
Conversation
…eBasedIntegrationTest Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
|
@dfordivam As discussed, I've included the switch to 1sv topology in this PR, now that TBAR bootstrap behavior is more comprehensively tested in #6392. Locally this reduces test wall clock runtime by 27%. There are other obvious stability benefits in the CI environment |
dfordivam
left a comment
There was a problem hiding this comment.
Looks fine, let's get review from Robert as well
|
Dont forget to revert https://github.com/canton-network/splice/pull/6386/changes |
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
added a comment |
|
Based on the conversation around the ingestion race causing flake, it occurred to me that making this 1 SV might increase the chances of flake. Because the DsoRules gets updated multiple times during round 0 for 4 SV, the |
rautenrieth-da
left a comment
There was a problem hiding this comment.
I'm not yet convinced this will make the test less flaky, but happy to try while we investigate the root cause.
|
As discussed, we'll continue to monitor this while we investigate the root cause |
Fixes #6420
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines