Skip to content

Address flakiness and latency in the Traffic-Based App Rewards integration test#6440

Merged
adetokunbo merged 4 commits into
mainfrom
adetokunbo/address-flakiness-and-latency-in-tbar-integration-test
Jul 16, 2026
Merged

Address flakiness and latency in the Traffic-Based App Rewards integration test#6440
adetokunbo merged 4 commits into
mainfrom
adetokunbo/address-flakiness-and-latency-in-tbar-integration-test

Conversation

@adetokunbo

Copy link
Copy Markdown
Contributor

Fixes #6420

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

…eBasedIntegrationTest

Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo

Copy link
Copy Markdown
Contributor Author

@dfordivam As discussed, I've included the switch to 1sv topology in this PR, now that TBAR bootstrap behavior is more comprehensively tested in #6392. Locally this reduces test wall clock runtime by 27%. There are other obvious stability benefits in the CI environment

@dfordivam dfordivam left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, let's get review from Robert as well

@dfordivam

dfordivam commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Dont forget to revert https://github.com/canton-network/splice/pull/6386/changes
Or add a comment why its ok to keep it removed

Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo

Copy link
Copy Markdown
Contributor Author

Dont forget to revert https://github.com/canton-network/splice/pull/6386/changes Or add a comment why its ok to keep it removed

added a comment

@dfordivam

Copy link
Copy Markdown
Contributor

Based on the conversation around the ingestion race causing flake, it occurred to me that making this 1 SV might increase the chances of flake. Because the DsoRules gets updated multiple times during round 0 for 4 SV, the DbScanRewardsReferenceStore has a higher chance of observing an archival of contract. With 1 SV the first archival the store sees might be round 0 archival.

@rautenrieth-da rautenrieth-da left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not yet convinced this will make the test less flaky, but happy to try while we investigate the root cause.

@adetokunbo
adetokunbo merged commit 26a02b2 into main Jul 16, 2026
120 of 122 checks passed
@adetokunbo
adetokunbo deleted the adetokunbo/address-flakiness-and-latency-in-tbar-integration-test branch July 16, 2026 09:41
@adetokunbo

Copy link
Copy Markdown
Contributor Author

As discussed, we'll continue to monitor this while we investigate the root cause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review advancing rounds in TrafficBasedRewardsTimeBasedIntegrationTest

3 participants