Skip to content

Unified URLs - #6455

Open
timpel-fcs wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/3022
Open

Unified URLs#6455
timpel-fcs wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/3022

Conversation

@timpel-fcs

Copy link
Copy Markdown
Contributor

Summary

Fixes #3022

  • Rename generic URL fields to Supporting URL across initiate-proposal forms and the review step
  • Add shared governance label constants and use them for vote reason and contract ID fields
  • Add copyable Proposal Link field on proposal details via getProposalLink(contractId)
  • Label vote reason text/URL in proposal details and cast-vote form as Vote Reason Summary / Vote Reason URL

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@timpel-fcs

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-07-16 at 15 49 11 Screenshot 2026-07-16 at 15 56 47

@pawelperek-da

@pawelperek-da
pawelperek-da self-requested a review July 17, 2026 10:53
@pawelperek-da

Copy link
Copy Markdown
Contributor

It needs a rebase to the new main @timpel-fcs

@timpel-fcs

Copy link
Copy Markdown
Contributor Author

rebased @pawelperek-da

@pawelperek-da

Copy link
Copy Markdown
Contributor

I think you missed [ci] in the commit message?

@timpel-fcs

Copy link
Copy Markdown
Contributor Author

ah sorry, was not aware of this workflow rule, added 🙏

@isegall-da

Copy link
Copy Markdown
Contributor

No need, PRs from forks by default use CI.

@isegall-da

Copy link
Copy Markdown
Contributor

(unless we broke that, of course)

@pawelperek-da

Copy link
Copy Markdown
Contributor

Probably I was just too impatient

Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refine URLs across SV UI app

6 participants