Skip to content

Add in-depth migration id validations and tests#6470

Open
timpel-fcs wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/2451
Open

Add in-depth migration id validations and tests#6470
timpel-fcs wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/2451

Conversation

@timpel-fcs

Copy link
Copy Markdown
Contributor

Summary

Fixes #2451

  • Derive current migration ID from DSO node state (highest sequencer migrationId) via getCurrentMigrationIdFromDsoInfo
  • Add migration ID format and increment validation with mutual-presence rules for upgrade time and migration ID
  • Extend ConfigField / SetDsoConfigRulesForm with Current migration ID and Current Configuration subtext
  • Only submit nextScheduledSynchronizerUpgrade when both upgrade fields are non-empty

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
@timpel-fcs

Copy link
Copy Markdown
Contributor Author

@pawelperek-da

Screenshot 2026-07-20 at 11 30 57 Screenshot 2026-07-20 at 11 31 02 Screenshot 2026-07-20 at 11 31 07 Screenshot 2026-07-20 at 11 31 12 Screenshot 2026-07-20 at 11 31 35

@ray-roestenburg-da

Copy link
Copy Markdown
Contributor

#2451 (comment)

This is a stale issues, this is not relevant anymore now that LSUs are in effect, the change is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement validation for nextScheduledSynchronizerUpgradeMigrationId config field

5 participants