Skip to content

SV UI: warn voters when locked config fields are altered (#5650)#6471

Open
puneetfinoa wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/5650
Open

SV UI: warn voters when locked config fields are altered (#5650)#6471
puneetfinoa wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:sv-ui/5650

Conversation

@puneetfinoa

@puneetfinoa puneetfinoa commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Warn on proposal details when a CRARC_SetConfig / SRARC_SetConfig proposal changes UI-disabled (locked) fields — the emergency/API path from #5650.
  • Highlight those changed rows in the proposed-changes list.
  • Wrap long pending/current config values in the create form so synchronizer IDs do not overflow the field column.
  • Create-UI locking for existing synchronizer fields was already in place; no backend lock API in this change.

Fixes #5650

Test plan

  • Unit: proposal-details-content.test.tsx — warning on/off (amulet + DSO)
  • Unit: pending-fields.test.tsx still passes after wrap fix
  • Manual: create emergency SetConfig via API, confirm warning + highlight in UI
  • Manual: normal editable-only SetConfig proposal has no warning
  • Manual: locked fields still not editable in create form
  • Screenshot attached for frontend review
Screenshot 2026-07-20 at 12 49 38

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

…etwork#5650)

Show a warning and highlight on proposal details when a SetConfig
vote alters UI-locked fields (emergency/API path). Also wrap long
pending config values in the create form so synchronizer IDs fit.

Signed-off-by: Puneet Bharti <puneet.bharti@finoa.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disabled fields cannot be set in the UI

5 participants