feat: added featured app revoke#2114
Open
phillip-cashen wants to merge 6 commits into
Open
Conversation
Signed-off-by: Phillip Olesen [Cashen] <phillip@cashen.cc>
Author
|
hey @rukmini-basu-da thanks for approving and merging with main! I am not able to start the workflows (they are awaiting approval) is that something you can do ? |
Signed-off-by: Phillip Olesen [Cashen] <phillip@cashen.cc>
Author
|
build had gotten broken because of this pr: I have updated a small fix above, @rukmini-basu-da can you approve workflows again ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey Wallet Team,
hope you are doing well, super cool repo you have here!
i took the liberty of adding a new feature to the featured app control, namely for revoking a featured app status. I tried as hard as possible to ensure it follow existing patterns and behavior of the repo.
i also added a little helper to scan-api that handles the annoyance of
scan.localhostwithout needing to changes/etc/hosts/files for the mapping (this makes it a lot easier to run the code for people not familiar with the repo).Looking forward to seeing your feedback and thoughts !