feat: add multi-session support#2161
Draft
alexmatson-da wants to merge 3 commits into
Draft
Conversation
Signed-off-by: Alex Matson <alex.matson@digitalasset.com>
Signed-off-by: Alex Matson <alex.matson@digitalasset.com>
Signed-off-by: Alex Matson <alex.matson@digitalasset.com>
mjuchli-da
reviewed
Jul 17, 2026
|
|
||
| export async function up(db: Kysely<DB>): Promise<void> { | ||
| console.log('Adding origin column to networks table') | ||
|
|
Contributor
There was a problem hiding this comment.
Session currently doesn't have a primary key. We should consider making the id the pk, as well as a unique constraint around origin, user_id. Then there's also the question of the access_token where i'm not sure if it's a good idea to make this unique, although it might very well be valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.