fix: add pagination to list tx - #2166
Merged
Merged
Conversation
rukmini-basu-da
force-pushed
the
rukmini/add-pagination-to-list-tx
branch
from
July 17, 2026 16:54
456d8cd to
9ccbb68
Compare
rukmini-basu-da
force-pushed
the
rukmini/add-pagination-to-list-tx
branch
3 times, most recently
from
July 20, 2026 20:30
4b49776 to
49e0283
Compare
rukmini-basu-da
marked this pull request as ready for review
July 20, 2026 20:30
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com>
rukmini-basu-da
force-pushed
the
rukmini/add-pagination-to-list-tx
branch
from
July 21, 2026 20:37
2a46e9a to
affb19f
Compare
mateuszpiatkowski-da
pushed a commit
that referenced
this pull request
Jul 22, 2026
* pagination Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * store sql test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * fix types Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * update user api controller Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * add pagination to store internal Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * use pagination in activities Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * refactor Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * refactor Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * fix computed total calculation Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * add total count Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * add test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * rename variables Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * fix test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * add test Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> * add tests for stores Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> --------- Signed-off-by: rukmini-basu-da <rukmini.basu@digitalasset.com> Signed-off-by: Mateusz Piątkowski <mateusz.piatkowski@digitalasset.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
listTransactionsuser-api and store interface to accept an optional parameter that consists of {limit: number, cursor: string}).The sql store and in memory implementations where both updated to query the same way with
createdAt desc nulls last, using theid descas the tiebreaker. The reason why the transactions tablecreatedAtcolumn is nullable (rather than something like currentTimestamp if not provided) is this was implemented for an audit trail andcurrentTimestampis not necessarily accurate (hence the additional paging logic). The store requests pageSize+1 items, so if an additional item is returned, we know there is a next page (and this element is removed before returning the payload and also determines thenextCursor).Lastly, the
user-ui-activitiesin the remote wallet-gateway used tolistTransactionsand get all the elements then implement pagination on the client side, so this was modified to usethis.transactionsas a paginated stream provided by the server. ThepageCursorsis sequentially cached where page 1 maps to undefined and as it's navigated forward, thenextCursoris sequentially cached, which helps with backwards/forwards traversal of the transactions pages.