Fix decryption of literal strings#130
Merged
Sharcoux merged 1 commit intocantoo-scribe:masterfrom Feb 17, 2026
Merged
Conversation
Collaborator
|
Perfect @onyck |
Collaborator
|
Released in v2.6.0 |
This was referenced Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the decryption of literal strings that contain escape sequences.
Fixes #122.
Why?
The current code decrypts literal strings without processing escape sequences. If an encrypted literal string does contain escape sequences, the decrypted value is nonsense and can cause issues such as #122.
Encrypted literal strings may contain escape sequences according to section 7.3.4.2 of the PDF 1.7 specification, so escape sequences should be resolved prior to decryption.
How?
This PR uses the existing
PDFString.asBytes()method to convert the literal string to a byte array while handling escape sequences. The byte array is then decrypted using the cipher transformer.Testing?
Added and ran unit tests.
New Dependencies?
No
Screenshots
N/A
Suggested Reading?
Yes
Anything Else?
N/A
Checklist