Pin GitHub Actions versions and add scheduled failure reporting - #13
Merged
Conversation
update_cap commits the refreshed run/input/core mirror nightly. Point to the policy recorded in builder-abap2UI5-js AGENTS.md: the mirror stays committed, bot-commit history is disposable (squashable to a baseline), and UPSTREAM_HEAD / UPSTREAM_COMMIT stay change-detection tokens that are never resolved against this repo's history. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013NA4sHtsK85U1f6YKxP7YW
Same alerting the abap2UI5 org already has (report-scheduled-failure): a red nightly means the CAP app stops following the core - surface it instead of failing silently. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013NA4sHtsK85U1f6YKxP7YW
Tag references (@v4/@v5/...) are mutable - a hijacked tag ships straight into CI. Pin every third-party action to the commit sha the tag currently resolves to (version noted in a comment), matching the convention the abap2UI5 org repos already follow. The ecosystem's own report-scheduled-failure composite stays on @main by convention. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013NA4sHtsK85U1f6YKxP7YW
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves workflow reliability and observability by pinning GitHub Actions to specific commit hashes and adding automated issue reporting for scheduled job failures.
Key Changes
actions/checkoutandactions/setup-nodeto use full commit hashes with version comments in bothupdate_cap.ymlandtest.ymlworkflows for reproducibility and securityreport-scheduled-failureaction inupdate_cap.ymlto automatically open issues when scheduled nightly runs failissues: writepermission toupdate_cap.ymlworkflow to support issue creation on failuresrun/input/coremirror, including guidance on squashing bot-commit history when neededImplementation Details
The failure reporting step only triggers on scheduled events (
github.event_name == 'schedule'), preventing noise from manual workflow runs. The pinned action versions improve supply chain security and ensure consistent behavior across workflow runs.https://claude.ai/code/session_013NA4sHtsK85U1f6YKxP7YW