Mirror the renamed core and follow it in the app source - #19
Merged
Conversation
The core package came back to life upstream (builder-abap2UI5-js: the 2026-08 rename wave plus the samples repository restructure), so the mirror moves to builder-abap2UI5-js@b9d31241bf2c. The app source follows the framework rename where it names framework classes: z2ui5-service.js wires abap2UI5/z2ui5_cl_ui5_http_handler, the starter and port-contract tests expect z2ui5_cl_ui5_app_start, and README / AGENTS.md name the current hello-world class, the current sample naming (z2ui5_cl_smp_app_*) and the smaller bundled catalog (~105 samples, down from ~180 — the samples repository moved every SAPUI5-only sample out). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHRfng5K6Yc8c4j7hBytXo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core package came back to life upstream (builder-abap2UI5-js: the 2026-08 rename wave plus the samples restructure), so the mirror moves to
builder-abap2UI5-js@b9d3124.Note this repo's nightly was green the whole time it was stalled: it kept mirroring an unchanged core, the app came out byte-identical and the publish step reported "app unchanged — no publish commit". Nothing to fix in the pipeline itself, the input had simply stopped moving.
What changes
run/input/core— the refreshed mirror (renamed framework classes, ~105 bundled samples, the newz2ui5_cl_ui5_view_builder)src/srv/z2ui5-service.js— wiresabap2UI5/z2ui5_cl_ui5_http_handler; the old name still resolves (the core ships it as a compat re-export), this just names the canonical onesrc/test/starter.test.js,src/test/port-contract.test.js— expectz2ui5_cl_ui5_app_startsrc/README.md,src/AGENTS.md— current hello-world class, current sample naming (z2ui5_cl_smp_app_*), catalog size ~105 instead of ~180Verification
npm test(builder scripts + the app's own jest suite against the assembled app) 18/18.Merge after builder-abap2UI5-js — merging this first would re-mirror the old, broken core on the next nightly.
🤖 Generated with Claude Code
https://claude.ai/code/session_01VHRfng5K6Yc8c4j7hBytXo
Generated by Claude Code