fix: ship html5-module build scaffolding for app/z2ui5 - #9
Merged
Conversation
The published app's mta.yaml declares the html5 module `abap2UI5` (path app/z2ui5) with build commands `npm install && npm run build:cf`, but app/z2ui5 shipped only a webapp/ folder — no package.json and no build:cf script. Every `mbt build` (the cap2UI5 deploy-check gate) died with `npm error Missing script: "build:cf"`, so the app was not CF-deployable. Add the missing scaffolding as siblings of webapp/ in src/app/z2ui5/ (assemble copies src/ verbatim and overlays only app/z2ui5/webapp, so these survive): - package.json — @ui5/cli devDep + `build:cf` (ui5 build → dist, then copies xs-app.json into dist so the HTML5-repo content is complete) - ui5.yaml — UI5 tooling config (type: application; the UI5 runtime is loaded at request time from the `ui5` destination, so the build only bundles the app's own Component-preload) - xs-app.json — managed-approuter routing: /resources + /test-resources to the ui5 destination, everything else to the html5-apps-repo runtime Verified end-to-end against the real core mirror: assemble keeps the scaffolding beside the overlaid webapp, and `npm install && npm run build:cf` produces a complete dist/ (Component-preload.js, manifest.json, index.html, xs-app.json). Add a regression test asserting the scaffolding survives the webapp overlay. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Hv64RwyNgeCDHqvUDrst7u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The published app's
mta.yamldeclares the html5 moduleabap2UI5(pathapp/z2ui5) with build commandsnpm install && npm run build:cf, butapp/z2ui5shipped only awebapp/folder — nopackage.jsonand nobuild:cfscript. Everymbt build(the cap2UI5deploy-checkgate) therefore died with:i.e. the generated app was not CF-deployable, and
cap2UI5's project status was red.Fix
Add the missing html5-module scaffolding as siblings of
webapp/insrc/app/z2ui5/.assemble-cap.jscopiessrc/verbatim and overlays onlyapp/z2ui5/webapp, so these files survive:package.json—@ui5/clidevDep +build:cf(ui5 build→dist, then copiesxs-app.jsonintodistso the HTML5-repo content is complete)ui5.yaml— UI5 tooling config (type: application; the UI5 runtime is loaded at request time from theui5destination, so the build only bundles the app's ownComponent-preload)xs-app.json— managed-approuter routing:/resources+/test-resources→ theui5destination, everything else → the html5-apps-repo runtimeVerification
Verified end-to-end against the real core mirror (
run/input/core):assemblekeeps the scaffolding beside the overlaidwebapp/npm install && npm run build:cfon the assembled output produces a completedist/(Component-preload.js,manifest.json,index.html,xs-app.json)Downstream effect
On merge to
main,update_capassembles and publishes the now-completeapp/z2ui5intocap2UI5/cap2UI5, making the app CF-deployable and turning itsdeploy-checkgreen.🤖 Generated with Claude Code
Generated by Claude Code