fix: prevent app from closing when changing icon on android - #80
Open
vsteenhoudt wants to merge 1 commit into
Open
fix: prevent app from closing when changing icon on android#80vsteenhoudt wants to merge 1 commit into
vsteenhoudt wants to merge 1 commit into
Conversation
Author
|
@johnborges |
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Android icon-switching logic to avoid disabling MainActivity during an icon change, which can cause the app process to be killed even when using PackageManager.DONT_KILL_APP. This aligns better with the documented Android setup where launcher entry points are handled via activity-alias.
Changes:
- Removed the
setComponentEnabledSetting(... MainActivity ..., DISABLED, DONT_KILL_APP)call fromchange(). - Added an explanatory comment indicating why
MainActivityshould not be disabled during runtime icon switching.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+76
to
+77
| // Do not disable main app icon | ||
| // DONT_KILL_APP will not work if we disable the currently enabled alias at runtime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabling the currently enabled alias will prevent the DONT_KILL_APP flag from working.
This will allow the change of the icon without the app closing on android.