feat: Android: Support apps whose application id differs from class package name - #89
Open
philet wants to merge 1 commit into
Conversation
…ackage name Usually the case if and app has test and production builds with different application ids.
There was a problem hiding this comment.
Pull request overview
This PR updates the Android implementation to support cases where the runtime applicationId (package name) differs from the Java/Kotlin class package, which commonly happens with productFlavors (e.g., test vs production builds).
Changes:
- Derive a
classPackageNamefrom the hostActivityclass and use it when building component class names. - Update
change()andreset()to enable/disable icon components using the class package rather than the runtime package name.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| pm.setComponentEnabledSetting( | ||
| new ComponentName(this.packageName, this.packageName + "." + enableName), | ||
| new ComponentName(this.packageName, this.classPackageName + "." + enableName), |
Comment on lines
+35
to
+41
| var fullClassName = activity.getClass().getName(); | ||
| int lastDot = fullClassName.lastIndexOf('.'); | ||
| if (lastDot != -1) { | ||
| this.classPackageName = fullClassName.substring(0, lastDot); | ||
| } else { | ||
| this.classPackageName = ""; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually the case if and app has test and production builds with different application ids.