[CHORE] #20 - Update example-app to use Capacitor 8 compatible plugin version (v8.0.0) - #24
Conversation
ryaa
left a comment
ryaa
left a comment
There was a problem hiding this comment.
PR Review Summary
I reviewed the PR and also validated the example app locally.
What looks good
- The example app changes themselves look correct for the Capacitor 8 migration scope.
- The example app dependencies were updated to Capacitor 8 / plugin v8.0.0.
- iOS and Android native config changes appear aligned with the Capacitor 8 baseline.
Validation result
I initially hit a blocker when building the example app on Node 20, because the Capacitor CLI now requires Node >=22.
After switching via nvm to Node 22, I was able to build and run the example app successfully, so the upgrade itself appears to be working correctly.
Remaining blocker
At this point, the only remaining blocker seems to be the repo Node version baseline.
The repo still has .nvmrc pinned to 20.11.1, which leads contributors to use a Node version that breaks the example-app Capacitor 8 flow.
Requested change
Please update .nvmrc to a Node 22 version so that the repo setup matches the actual requirements of the upgraded example app.
It may also be worth updating any related CI/docs in a follow-up for consistency, but from my review the key required fix for this PR is the .nvmrc bump.
Review outcome
Request changes
Once .nvmrc is updated to Node 22, I believe this PR should be in good shape.
@andreimuha-ionic can you please take a look? thank you
…on (v8.0.0) #20 Changes: - Updated the repo Node baseline in `.nvmrc` from `20.11.1` to `22.0.0` so local setup matches the Capacitor 8 example-app CLI requirement.
2 participants
No description provided.