This repository was archived by the owner on Sep 26, 2022. It is now read-only.
(Draft) Feat: ability to abort requests#198
Draft
dfidalg0 wants to merge 7 commits intocapacitor-community:mainfrom
Draft
(Draft) Feat: ability to abort requests#198dfidalg0 wants to merge 7 commits intocapacitor-community:mainfrom
dfidalg0 wants to merge 7 commits intocapacitor-community:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is basically the same as #193, but as a draft PR as suggested by @thomasvidas.
The proposal is to have a request abort API that behaves similar to the standard fetch API.
Currently, the implementation supports only web and Android, since I don't have a Macbook and don't know how to properly implement this in Swift. So, any help is welcome 🤓
For those willing to implement the iOS part, the main ideia is
signalparameter({ aborted: boolean; abortCode: integer; })passed down to the plugin call and track the corresponding socket (requests that don't have a signal shouldn't be tracked).__abortRequestthat receives a{ abortCode: integer }and interrupts the corresponding socket.