fix(rpc): Use correct SDK endpoint for DID registration by beonde · Pull Request #33 · capiscio/capiscio-core

beonde · 2026-02-16T22:16:40Z

Summary

Fixes the DID registration endpoint in the SimpleGuard Init RPC to align with the server's SDK API.

Changes

`internal/rpc/simpleguard_service.go`

Before	After
`POST /v1/agents/{id}/dids`	`PUT /v1/sdk/agents/{id}`
`Authorization: Bearer {key}`	`X-Capiscio-Registry-Key: {key}`
`{"did": "...", "public_key": "..."}`	`{"did": "..."}`

Root Cause

The sidecar was calling a non-existent endpoint. The server's SDK routes use:

PUT /v1/sdk/agents/{id} for updating agent properties including DID
X-Capiscio-Registry-Key header for API key authentication

Related PRs

capiscio/capiscio-server#27 - API key auth fix for UpdateAgent/GetAgent handlers
fix(connect): Create agent when name specified but not found capiscio-sdk-python#29 - SDK connect flow improvements

Testing

This change enables the full Let's Encrypt-style CapiscIO.connect() flow to work end-to-end with the live registry.

- Change endpoint from /v1/agents/{id}/dids to /v1/sdk/agents/{id} - Change HTTP method from POST to PUT (update existing agent) - Change auth header from Authorization: Bearer to X-Capiscio-Registry-Key - Remove public_key from payload (not needed for DID update) This aligns the core sidecar with the server's SDK API.

codecov · 2026-02-16T22:18:02Z

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
internal/rpc/simpleguard_service.go	85.71%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

Fixes the SimpleGuard Init DID registration call to use the server’s SDK update-agent endpoint and API-key header so the connect/init flow can successfully register an agent DID.

Changes:

Switch DID registration from POST /v1/agents/{id}/dids to PUT /v1/sdk/agents/{id}.
Use X-Capiscio-Registry-Key header instead of Authorization: Bearer.
Update request body to only include {"did": "..."}.

Copilot · 2026-02-16T22:19:51Z

internal/rpc/simpleguard_service.go

+// Uses PUT /v1/sdk/agents/{id} to update the agent's DID.
 func (s *SimpleGuardService) registerDIDWithServer(serverURL, apiKey, agentID, didKey string, publicKeyJWK []byte) error {
-	url := fmt.Sprintf("%s/v1/agents/%s/dids", serverURL, agentID)
+	url := fmt.Sprintf("%s/v1/sdk/agents/%s", serverURL, agentID)


serverURL is concatenated directly into the request URL; if callers provide a trailing slash (e.g. https://api.capisc.io/), this produces a double-slash path (//v1/...) which can trigger redirects or routing mismatches on some servers. Consider normalizing serverURL (trim trailing /) or building the URL with url.JoinPath.

Copilot · 2026-02-16T22:19:52Z

internal/rpc/simpleguard_service.go

+	req, err := http.NewRequest(http.MethodPut, url, bytes.NewReader(body))
 	if err != nil {
 		return fmt.Errorf("failed to create request: %w", err)
 	}

 	req.Header.Set("Content-Type", "application/json")
-	req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", apiKey))
+	req.Header.Set("X-Capiscio-Registry-Key", apiKey)


The DID registration flow changed (method/path/header/payload), but there’s no unit test coverage asserting the new PUT /v1/sdk/agents/{id} call and X-Capiscio-Registry-Key header. Add a test (likely via httptest.Server) that exercises Init (or registerDIDWithServer) and verifies the request method, path, header, and JSON body.

Copilot · 2026-02-16T22:19:52Z

internal/rpc/simpleguard_service.go


 // registerDIDWithServer registers DID with the CapiscIO server.
+// Uses PUT /v1/sdk/agents/{id} to update the agent's DID.
 func (s *SimpleGuardService) registerDIDWithServer(serverURL, apiKey, agentID, didKey string, publicKeyJWK []byte) error {


publicKeyJWK is still part of the registerDIDWithServer signature (and is passed from Init), but it’s no longer used in the payload. This makes the call site misleading and can become lint noise if unparam is enabled later. Remove the parameter and the extra argument at the call site (or, if the server still needs the key in some form, include it explicitly in the request body).

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-16T22:35:02Z

internal/rpc/simpleguard_service.go


 // registerDIDWithServer registers DID with the CapiscIO server.
+// Uses PUT /v1/sdk/agents/{id} to update the agent's DID.
 func (s *SimpleGuardService) registerDIDWithServer(serverURL, apiKey, agentID, didKey string, publicKeyJWK []byte) error {


The publicKeyJWK parameter is no longer used in this function since the payload was updated to only include the DID. Consider removing this parameter from the function signature to avoid confusion and maintain a cleaner API.

- Remove unused publicKeyJWK parameter - Normalize serverURL to prevent double-slash issues - Use strings.TrimRight to handle trailing slashes

- Add tests for RPC registerDIDWithServer function - Update CLI registerDID to use new SDK endpoint - Update CLI tests for new endpoint pattern - Tests cover: successful registration, URL normalization, server errors, unauthorized responses

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copilot · 2026-02-17T20:44:43Z

internal/rpc/simpleguard_service_test.go

+		var gotMethod, gotPath, gotAPIKey string
+
+		server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			gotMethod = r.Method
+			gotPath = r.URL.Path
+			gotAPIKey = r.Header.Get("X-Capiscio-Registry-Key")
+			json.NewDecoder(r.Body).Decode(&received)
+			w.WriteHeader(http.StatusOK)


The test writes to shared variables (gotMethod/gotPath/gotAPIKey/received) from the httptest server handler goroutine and reads them back in the test goroutine without synchronization. This will trigger data races under go test -race. Prefer asserting inside the handler, or send the captured values back over a channel / protect with a mutex.

Copilot · 2026-02-17T20:44:43Z

cmd/capiscio/init_test.go

 func TestRegisterDID(t *testing.T) {
 	var received struct {
-		DID       string          `json:"did"`
-		PublicKey json.RawMessage `json:"public_key"`
+		DID string `json:"did"`
 	}


This test relies on the httptest handler mutating received (and then the main test goroutine asserting on it) without synchronization. Because handlers run in a separate goroutine, this is a data race under go test -race. Consider performing assertions inside the handler, or communicate the decoded body back via a channel/mutex.

Copilot · 2026-02-17T20:44:43Z

cmd/capiscio/init.go

+	// Note: public key is no longer sent - server doesn't require it for SDK registration
+	_ = pub // Kept in signature for backward compatibility


registerDID no longer uses the pub argument, but it is still part of the (unexported) function signature and is manually discarded. Since this function is only used within this package/file, it would be clearer to remove the parameter and update the call sites instead of keeping an intentionally-unused argument.

Suggested change

// Note: public key is no longer sent - server doesn't require it for SDK registration

_ = pub // Kept in signature for backward compatibility

// Note: public key is no longer sent - server doesn't require it for SDK registration.

// The pub parameter is retained for backward compatibility and is currently unused.

- Fix race conditions in tests using channels for thread-safe communication - Improve comment style for unused pub parameter per review suggestion - Tests now pass with -race flag

Copilot AI review requested due to automatic review settings February 16, 2026 22:16

Copilot started reviewing on behalf of beonde February 16, 2026 22:17 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

beonde requested a review from Copilot February 16, 2026 22:32

Copilot started reviewing on behalf of beonde February 16, 2026 22:32 View session

Copilot AI reviewed Feb 16, 2026

View reviewed changes

beonde added 2 commits February 17, 2026 00:41

fix(rpc): Address Copilot review feedback

598dcda

- Remove unused publicKeyJWK parameter - Normalize serverURL to prevent double-slash issues - Use strings.TrimRight to handle trailing slashes

test: Add coverage for registerDIDWithServer

3c06c99

- Add tests for RPC registerDIDWithServer function - Update CLI registerDID to use new SDK endpoint - Update CLI tests for new endpoint pattern - Tests cover: successful registration, URL normalization, server errors, unauthorized responses

Copilot AI review requested due to automatic review settings February 17, 2026 20:41

Copilot started reviewing on behalf of beonde February 17, 2026 20:41 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

fix: Address Copilot review comments

74e2767

- Fix race conditions in tests using channels for thread-safe communication - Improve comment style for unused pub parameter per review suggestion - Tests now pass with -race flag

beonde merged commit be5c73b into main Feb 17, 2026
3 checks passed

beonde deleted the fix/did-registration-endpoint branch February 17, 2026 22:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(rpc): Use correct SDK endpoint for DID registration#33

fix(rpc): Use correct SDK endpoint for DID registration#33
beonde merged 4 commits intomainfrom
fix/did-registration-endpoint

beonde commented Feb 16, 2026

Uh oh!

codecov bot commented Feb 16, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Copilot AI Feb 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

		// Note: public key is no longer sent - server doesn't require it for SDK registration
		_ = pub // Kept in signature for backward compatibility

Conversation

beonde commented Feb 16, 2026

Summary

Changes

internal/rpc/simpleguard_service.go

Root Cause

Related PRs

Testing

Uh oh!

codecov bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

`internal/rpc/simpleguard_service.go`

codecov bot commented Feb 16, 2026 •

edited

Loading