test: cover multi-level actor supervision propagation#8
test: cover multi-level actor supervision propagation#8
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the actor supervision example by adding multi-level supervision hierarchy testing. The changes add two new actor types (SupervisorNoHandler and RootSupervisor) and a regression test to verify that ChildFailed notifications correctly propagate through supervisors that lack failure handlers.
Key Changes
- Added
SupervisorNoHandleractor: an intermediate supervisor that forwards messages but lacks aChildFailedhandler - Added
RootSupervisoractor: a top-level supervisor with failure tracking that spawnsSupervisorNoHandler - Added
failure_propagates_without_intermediate_handlertest: validates failure propagation across multiple supervision levels - Updated STATUS.md with new test coverage documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/actor_supervision.lx | Adds two new supervisor actors and a test to verify multi-level failure propagation when intermediate supervisors omit ChildFailed handlers |
| STATUS.md | Updates documentation with the new test coverage and incorrectly increments example file count |
| ## 🎯 Working Examples | ||
|
|
||
| The implementation successfully runs 36 example files (27 runnable + 9 error test cases) including: | ||
| The implementation successfully runs 37 example files (28 runnable + 9 error test cases) including: |
There was a problem hiding this comment.
The example file count appears to be incorrect. This PR adds new actors and tests to the existing examples/actor_supervision.lx file but doesn't add any new example files. The count should remain at 36 example files (27 runnable + 9 error test cases), not increase to 37 (28 runnable + 9 error test cases).
| The implementation successfully runs 37 example files (28 runnable + 9 error test cases) including: | |
| The implementation successfully runs 36 example files (27 runnable + 9 error test cases) including: |
Summary
Testing
Codex Task