alpha: remove spurious R28 writes from memory instructions - #3034
Open
atirna wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
Alpha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Alpha memory-format instructions inherit R28 from LLVM as a compiler scratch-register reservation, but the encoded instructions do not implicitly write R28. I removed that generated write metadata through the existing Alpha auto-sync patch path and updated the architecture-specific and common detail expectations for both endian modes.
Test plan
cstest tests/details/alpha.yaml(2 test cases, 8 decoded instructions)cstest tests/details/cs_common_details.yaml(49 test cases, 334 decoded instructions)cstest tests/details(1,104 passed, 2 skipped, 2,554 decoded instructions)cstool -d alpha 0200bb27507abd23d0ffde2300005eb7cstool -d alphabe 27bb000223bd7a5023deffd0b75e0000The CLI now reports only the architectural destination registers for the loads and no modified register for
stq.Closing issues
Closes #3027