Skip to content

Add resource filtering functionality #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
ccp-chargeback wants to merge 50 commits into
base: main
Choose a base branch
from
Draft

Add resource filtering functionality #14

ccp-chargeback wants to merge 50 commits into from
+4,124 −79

Conversation

@ccp-chargeback
Copy link
Collaborator

@ccp-chargeback ccp-chargeback commented Jan 26, 2026

Allow filtering of included resource files based on rules defined in one or more supplied filter.ini files.

The change contains:

  • Reading and parsing of .ini filter files.
  • Allow overrides of include/exclude rules
  • Support wildcard filters:
    • "*" = current folder
    • "..." = any subfolder
  • Define priorities for include/exclude filter:
    • Based on folder/file hierarcy
    • Include/Exclude sameName file based on its hierarcy in each
  • Add CLI integration
  • Add loads of test coverage

@ccp-chargeback
Add example1.ini file (for tests)
fbb3830
@ccp-chargeback
Add vcpkg inih to project
31479c2
@ccp-chargeback
Add first ResourceFilterTest
9ce31fa
@ccp-chargeback
Update ExampleIniParsing test
4a0a0d8 
Make use of existing filePath test functions
@ccp-chargeback
Rename the ResourceFilterTest class
dbbfb83
@ccp-chargeback
Add scaffolding for the Filter classes
fd26db0
@ccp-chargeback
Include exclude filter implementation without regex
40ec602
@ccp-chargeback
Simplify FilterResourceFilter::ParseFilters()
ede9636
@ccp-chargeback
Add error tests for FilterResourceFilter::ParseFilters()
b79fe7e
@ccp-chargeback
Add tests for Condensed but valid filter strings
a2bd883
@ccp-chargeback
Add Doxygen markdown comments to FilterResourceFilter class.
1a406b3
@ccp-chargeback
Change scaffolding of FilterResourceFilter
c65e3c4
@ccp-chargeback
Move Filter logic into tools
5d151d0
@ccp-chargeback
Make filter tool classes part of ResourceTools namespace
c8b8bcd
@ccp-chargeback
Fix Filter tests to now use new ResourceTools namespace
5fed2b9
@ccp-chargeback
Add test for multiline respaths with empty lines
369e3c8
@ccp-chargeback
Refactor of ResourceLing and PrefixMap
f9d4965
@ccp-chargeback
Add FilterPrefixMap and Entry classes
8a68f53 
Next step, add missing tests.
@ccp-chargeback
Add tests for FilterPrefixMap and Entry
e90027b
@ccp-chargeback
Include and function signature cleanup
cd967c2
@ccp-chargeback
Add tests for class FilterDefaultSection
a84ebd9
@ccp-chargeback
Fixup NamedSection and related classes.
12e4d74
@ccp-chargeback
Add test for Duplicate Filter in Overrides
3ce25ae
@ccp-chargeback
Change m_parentPrefixMap to a const reference
f96197d 
Also fixed clang-tidy suggestions
@ccp-chargeback
Change m_parentSectionFilter to a const reference
698874b
@ccp-chargeback
Remove un-necessary default constructors
74de122
@ccp-chargeback
Rename and gorup Resource Filter tests by class tested
022b0cf
@ccp-chargeback
Add FilterNamedSection tests
7b31e28
@ccp-chargeback
Add FilterResourceFile class
073a220 
- Do some function name changes to reduce stuttering.
@ccp-chargeback
Add test for FilterResourceFile class (example1.ini)
c885982
@ccp-chargeback
Treat empty top-level and inline filters differently
b842fb7 
Needed to support:
- Empty or undefined top-level filter (which should add a "*" include)
- Inline exclude filter ONLY (which should NOT add a "*" include) in the combined output.

Fixed and added a bunch of tests
@ccp-chargeback
Add tests for NamedSection different inline filters
c82711e
@ccp-chargeback
Add tests for loading invalid example .ini files
825ffee
@ccp-chargeback
Add ResourceFilter class
183d0c0 
- Hook it up to the ResourceGroupImplementation
- Add some basic tests for the functionality
@ccp-chargeback
Merge branch 'main' into add-resource-filtering
4ecb4a7 
# Conflicts:
#	include/ResourceGroup.h
@ccp-chargeback
Fix formatting
42f2006
@ccp-chargeback
Remove TODOs
eb4917e 
- No need as the top-level ResourceGroupImpl one will return the correct top-level error code to the caller.
@ccp-chargeback
Add a complex include/exclude via different relative paths test
31989f8 
- The test should cover most (if not all) realistic mutations of same file(s) via different prefixmap relative paths includes/excludes.
@ccp-chargeback
Add ResourceFilter test using two .ini files
93b6942
@ccp-chargeback
Hook up CLI argument --filter-files
cf59252
@ccp-chargeback
Make the CurrentWorkingDirectoryChanger helper class available for al…
5158d92 
…l tests.
@ccp-chargeback
Add resourceFilterIniFiles info to PrintStartBanner()
6d3c1fb
@ccp-chargeback
Make CLI parameter --filter-files singular
cec67ec
@ccp-chargeback
Update helpString for --filter-file
43bdd0f
@ccp-chargeback
Create CLI test for filtering using validSimpleExample1.ini
bef0e53
@ccp-chargeback
Create more CLI filter tests
201dcff 
Added test for:
- validComplexExample1
- combined validSimpleExample1 + validComplexExample1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CCPCookies CCPCookies Awaiting requested review from CCPCookies

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ccp-chargeback