Added lots of new features#4
Added lots of new features#4DjinnGA wants to merge 4 commits intocarolight:masterfrom DjinnGA:master
Conversation
|
Hi, Giles - I'm just having a first look at your merge files - your setTextAlignment has NSTextAlignmentLeft etc - should that be UITextAlignmentLeft etc? I'm wondering why you chose NS.... Caroline On 21/10/2012, at 11:59 AM, Giles Allensby wrote:
|
|
Hi I know it looks odd because NS is normally for Mac OS applications I myself found this odd at the time but Apples UITextField documentation found here: states to use @Property(nonatomic) NSTextAlignment textAlignment This is the same for UILabel found here: Regards, |
|
That's the property declaration though, not the value. I can't get it to compile unless I change them to UI... - is that OK with you if I do? Or how did you get your uikit.mm to compile? Caroline On 22/10/2012, at 12:21 PM, Giles Allensby wrote:
|
|
Mine has no issues compiling as I have used it in one of my applications to set the alignment to centre. Giles |
|
I wonder how yours compiles then, and mine doesn't. This is a screen capture of the error - you can see that where I have fixed it, there is no error. On 22/10/2012, at 1:15 PM, Giles Allensby wrote:
|
|
Are you compiling for iOS 6.0? On 22/10/2012, at 1:15 PM, Giles Allensby wrote:
|
|
I don't appear to be able to see your screenshot. Yes I am currently compiling for iPhone 6.0 simulator using Xcode 4.5 |
|
That's probably it then, because I'm compiling for iOS 5. I haven't installed 6 on my system yet. Google says that "The NSTextAlignmentNatural value is unsupported and will be removed in a future seed". Searching for NSTextAlignmentNatural shows up this link among others: If I change them all to be UI... then I can't use AlignmentNatural or AlignmentJustified. These weren't available in earlier versions, so to support earlier versions, we probably shouldn't use them. On 22/10/2012, at 1:27 PM, Giles Allensby wrote:
|
|
Ok that makes sense then. |
|
Thanks :) - it's a pain supporting older versions. For my own apps in Objective C, I've decided not to support less than 5.0. On 22/10/2012, at 1:38 PM, Giles Allensby wrote:
|
|
Hey, Giles - I've been having a bad week, so didn't finalise the merge - sorry. I've just updated to Xcode 4.5, and your changes worked as is, and also worked on the 4.3 simulator. So it's a feature of Xcode, not the iOS. So I'm trying to merge your code as is, but there's a conflict. On github.com it says "This pull request cannot be automatically merged." So I looked at the information, and followed instructions by switching to your branch on my computer, and it says "Merge conflict in Plugin/uikit.mm". So now I have no idea what to do. Should I just upload your uikit.mm as is, overwriting mine? Do you know anything about github? I know almost zero about it. Caroline On 22/10/2012, at 1:38 PM, Giles Allensby wrote:
|
|
I think it might be because your changes conflict with something that I've subsequently done: It seems that your line goes behind mine. So I have no idea what to do now :(. Caroline On 22/10/2012, at 1:38 PM, Giles Allensby wrote:
|
set default Table View style to plain if not specified
View:
Button:
Label:
Transparent BG by default
TextField2:
PickerView:
TableView: