Skip to content

Added lots of new features#4

Open
DjinnGA wants to merge 4 commits intocarolight:masterfrom
DjinnGA:master
Open

Added lots of new features#4
DjinnGA wants to merge 4 commits intocarolight:masterfrom
DjinnGA:master

Conversation

@DjinnGA
Copy link
Contributor

@DjinnGA DjinnGA commented Oct 21, 2012

set default Table View style to plain if not specified

View:

  • void setAlpha(float alpha)
  • void animateNow(int x, int y, int width, int height, float duration, float delay, String animType)

Button:

  • void setTextAlignment(string alignment)

Label:
Transparent BG by default

  • void setTextAlign(string align)

TextField2:

  • void hideKeyboard()
  • void setReturnKeyType(string type)
  • void setBorderStyle(string style)
  • void setKeyboardType(string type)
  • void setClearButton(string type)
  • void setKeyboardAppearance(string style)
  • void setTextAlign(string align)

PickerView:

  • void showSelectionIndicator(BOOL show)

TableView:

  • void removeRow(int rowNum, int sectNum, string animStyle)
  • void setAccessoryType(string accessoryType)
  • void deselectRow(int rowNum, int sectNum, BOOL anim)

@carolight
Copy link
Owner

Hi, Giles - I'm just having a first look at your merge files - your setTextAlignment has NSTextAlignmentLeft etc - should that be UITextAlignmentLeft etc? I'm wondering why you chose NS....

Caroline

On 21/10/2012, at 11:59 AM, Giles Allensby wrote:

set default Table View style to plain if not specified

View:

void setAlpha(float alpha)
void animateNow(int x, int y, int width, int height, float duration, float delay, String animType)
Button:

void setTextAlignment(string alignment)
Label:
Transparent BG by default

void setTextAlign(string align)
TextField2:

void hideKeyboard()
void setReturnKeyType(string type)
void setBorderStyle(string style)
void setKeyboardType(string type)
void setClearButton(string type)
void setKeyboardAppearance(string style)
void setTextAlign(string align)
PickerView:

void showSelectionIndicator(BOOL show)
TableView:

void removeRow(int rowNum, int sectNum, string animStyle)
void setAccessoryType(string accessoryType)
void deselectRow(int rowNum, int sectNum, BOOL anim)
You can merge this Pull Request by running:

git pull https://github.com/SimpleLoop/MHUIKit master
Or view, comment on, or merge it at:

#4

Commit Summary

Anims, Alpha, More
Default table view style
Updated Readme
changed date on readme
File Changes

M Plugin/uikit.mm (584)
M README (47)
A TableView Example/.tmp/UIKitTableView.md5 (0)
Patch Links

https://github.com/carolight/MHUIKit/pull/4.patch
https://github.com/carolight/MHUIKit/pull/4.diff

Reply to this email directly or view it on GitHub.

@DjinnGA
Copy link
Contributor Author

DjinnGA commented Oct 22, 2012

Hi

I know it looks odd because NS is normally for Mac OS applications I myself found this odd at the time but Apples UITextField documentation found here:
http://developer.apple.com/library/ios/#documentation/uikit/reference/UITextField_Class/Reference/UITextField.html

states to use @Property(nonatomic) NSTextAlignment textAlignment

This is the same for UILabel found here:
http://developer.apple.com/library/ios/#documentation/UIKit/Reference/UILabel_Class/Reference/UILabel.html

Regards,
Giles

@carolight
Copy link
Owner

That's the property declaration though, not the value.

I can't get it to compile unless I change them to UI... - is that OK with you if I do? Or how did you get your uikit.mm to compile?

Caroline

On 22/10/2012, at 12:21 PM, Giles Allensby wrote:

Hi

I know it looks odd because NS is normally for Mac OS applications I myself found this odd at the time but Apples UITextField documentation found here:
http://developer.apple.com/library/ios/#documentation/uikit/reference/UITextField_Class/Reference/UITextField.html

states to use @Property(nonatomic) NSTextAlignment textAlignment

This is the same for UILabel found here:
http://developer.apple.com/library/ios/#documentation/UIKit/Reference/UILabel_Class/Reference/UILabel.html

Regards,
Giles


Reply to this email directly or view it on GitHub.

@DjinnGA
Copy link
Contributor Author

DjinnGA commented Oct 22, 2012

Mine has no issues compiling as I have used it in one of my applications to set the alignment to centre.
I used NS because that is the way the documentation says to do it and there are more options for NS than there are for UI.
I do not see how the use of NS could cause a problem if it is how the documentation for NSText field states to do it.
What is the error you are receiving when trying to compile?

Giles

@carolight
Copy link
Owner

I wonder how yours compiles then, and mine doesn't.

This is a screen capture of the error - you can see that where I have fixed it, there is no error.

On 22/10/2012, at 1:15 PM, Giles Allensby wrote:

Mine has no issues compiling as I have used it in one of my applications to set the alignment to centre.
I used NS because that is the way the documentation says to do it and there are more options for NS than there are for UI.
I do not see how the use of NS could cause a problem if it is how the documentation for NSText field states to do it.
What is the error you are receiving when trying to compile?

Giles


Reply to this email directly or view it on GitHub.

@carolight
Copy link
Owner

Are you compiling for iOS 6.0?

On 22/10/2012, at 1:15 PM, Giles Allensby wrote:

Mine has no issues compiling as I have used it in one of my applications to set the alignment to centre.
I used NS because that is the way the documentation says to do it and there are more options for NS than there are for UI.
I do not see how the use of NS could cause a problem if it is how the documentation for NSText field states to do it.
What is the error you are receiving when trying to compile?

Giles


Reply to this email directly or view it on GitHub.

@DjinnGA
Copy link
Contributor Author

DjinnGA commented Oct 22, 2012

I don't appear to be able to see your screenshot.

Yes I am currently compiling for iPhone 6.0 simulator using Xcode 4.5

@carolight
Copy link
Owner

That's probably it then, because I'm compiling for iOS 5. I haven't installed 6 on my system yet.

Google says that "The NSTextAlignmentNatural value is unsupported and will be removed in a future seed".

Searching for NSTextAlignmentNatural shows up this link among others:
http://www.bgr.com/2012/06/11/ios-6-beta-download-link-iphone-ipad-ipod-touch-release/

If I change them all to be UI... then I can't use AlignmentNatural or AlignmentJustified. These weren't available in earlier versions, so to support earlier versions, we probably shouldn't use them.

On 22/10/2012, at 1:27 PM, Giles Allensby wrote:

I don't appear to be able to see your screenshot.

Yes I am currently compiling for iPhone 6.0 simulator using Xcode 4.5


Reply to this email directly or view it on GitHub.

@DjinnGA
Copy link
Contributor Author

DjinnGA commented Oct 22, 2012

Ok that makes sense then.
Feel free to change it to support older versions then.
I was just following the documentation :).

@carolight
Copy link
Owner

Thanks :) - it's a pain supporting older versions. For my own apps in Objective C, I've decided not to support less than 5.0.

On 22/10/2012, at 1:38 PM, Giles Allensby wrote:

Ok that makes sense then.
Feel free to change it to support older versions then.
I was just following the documentation :).


Reply to this email directly or view it on GitHub.

@carolight
Copy link
Owner

Hey, Giles - I've been having a bad week, so didn't finalise the merge - sorry.

I've just updated to Xcode 4.5, and your changes worked as is, and also worked on the 4.3 simulator. So it's a feature of Xcode, not the iOS.

So I'm trying to merge your code as is, but there's a conflict.

On github.com it says "This pull request cannot be automatically merged."

So I looked at the information, and followed instructions by switching to your branch on my computer, and it says "Merge conflict in Plugin/uikit.mm".

So now I have no idea what to do.

Should I just upload your uikit.mm as is, overwriting mine? Do you know anything about github? I know almost zero about it.

Caroline

On 22/10/2012, at 1:38 PM, Giles Allensby wrote:

Ok that makes sense then.
Feel free to change it to support older versions then.
I was just following the documentation :).


Reply to this email directly or view it on GitHub.

@carolight
Copy link
Owner

I think it might be because your changes conflict with something that I've subsequently done:

It seems that your line goes behind mine.

So I have no idea what to do now :(.

Caroline

On 22/10/2012, at 1:38 PM, Giles Allensby wrote:

Ok that makes sense then.
Feel free to change it to support older versions then.
I was just following the documentation :).


Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants