Replace .gitkeep files with useful explanation of folder purpose#235
Open
katrinleinweber wants to merge 4 commits intocarpentries:mainfrom
Open
Replace .gitkeep files with useful explanation of folder purpose#235katrinleinweber wants to merge 4 commits intocarpentries:mainfrom
katrinleinweber wants to merge 4 commits intocarpentries:mainfrom
Conversation
Contributor
Author
|
The build error does not seem to be related to these changes: |
Contributor
|
The relevant build error is: it is triggered because the Travis file is not set up for R (only Python), and hence the environment variables and library aren't set up to allow package installation. |
Contributor
Author
|
OK, thanks for explaining. Please feel free to hide my above comment about the resulting error. Let's focus on the suggested changes again. |
Contributor
Author
|
I found a possibly even cleaner way to avoid (almost) empty folders: What do you think @rgaiacs & @fmichonneau? Since the makefiles of both lesson-example and styles have the same commit history, I guess such commits should be PR'ed towards the Also: Happy new year, and all the best for 2019 :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As discussed in #234.
make serveis not impacted in any way that I notice. Is the initial text in theReadMe.mdfiles factually correct?