fix: update bindings, fix tests#239
Open
stephenctw wants to merge 1 commit intofeature/bump-emulator-2from
Open
fix: update bindings, fix tests#239stephenctw wants to merge 1 commit intofeature/bump-emulator-2from
stephenctw wants to merge 1 commit intofeature/bump-emulator-2from
Conversation
mpolitzer
reviewed
Feb 10, 2026
| self.machine, | ||
| dir_cstr.as_ptr(), | ||
| cartesi_machine_sys::CM_SHARING_CONFIG, | ||
| cartesi_machine_sys::CM_SHARING_ALL, |
There was a problem hiding this comment.
tldr; this change is correct.
I asked the machine team about this function.
The answer is that they are future proofing it for lambda.
For now this(CM_SHARING_ALL) option is the only that makes sense.
GCdePaula
reviewed
Feb 14, 2026
Collaborator
GCdePaula
left a comment
GCdePaula
left a comment
There was a problem hiding this comment.
Why the "serde default" everywhere? Like, what changed in the new machine version that required us to add this "serde default"? Can you also explain what this default does?
Collaborator
There was a problem hiding this comment.
How will this change behave if we need to use an unreleased machine?
Collaborator
There was a problem hiding this comment.
Do we need these changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@GCdePaula Could you help taking a second look at the Rust-bindings. They are mostly done by AI agent, which works now, but you might want to make some changes.