Skip to content

fix: fix reason extraction #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephenctw merged 1 commit into from
Sep 19, 2025
Merged

fix: fix reason extraction #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/AdvanceStatus.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ library AdvanceStatus {
} cmt_io_yield_t;
*/

error InvalidReason(uint16 reason);

function advanceStatus(AccessLogs.Context memory a)
internal
pure
Expand All @@ -55,7 +57,7 @@ library AdvanceStatus {

uint64 tohost =
EmulatorCompat.readWord(a, EmulatorConstants.HTIF_TOHOST_ADDRESS);
uint16 reason = uint16((tohost >> 16) & ((1 << 16) - 1));
uint16 reason = uint16(tohost >> 32);

if (reason == EmulatorConstants.CMIO_YIELD_MANUAL_REASON_RX_ACCEPTED) {
return Status.ACCEPTED;
Expand All @@ -68,7 +70,7 @@ library AdvanceStatus {
) {
return Status.EXCEPTION;
} else {
revert("Invalid reason");
revert InvalidReason(reason);
}
}
}