Feat: Rollups v2 support#52
Feat: Rollups v2 support#52brunomenezes merged 16 commits intoprerelease/rollups-v2-support-alphafrom
Conversation
|
Hey @tuler, could you confirm my bullet point 3 about the |
98000e3 to
f04be0e
Compare
…d v2 apps. Also, exclude non-usual-apps (i.e. created by input-added evts).
…nclude v2 apps for ownership-transferred logs.
f04be0e to
cd50c6d
Compare
|
When testing this at cartesi/cli#172 In get the following error: |
…i production to purge it.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.
|
A new package was generated. Something changed from previous builds when using the @endersonmaia you can pull the latest image. |
|
@brunomenezes sorry for the late response, U just executed with latest image, and I see no error in the logs But after deploying an application and sending some inputs, I still can't see them in the WebUI, but I think it's a work in progress, right ? |
Hey @endersonmaia, if you are seeing the events been indexed in the logs (apps created, input added and etc) by using the latest ui rollups-v2 branch you should see the content in the rollups-explorer-ui. I use the comet-app as my test dapp after migrating to node-v2 + espresso. What do you see in the API and UI app logs? |
|
I think I found the problem, squid_processor is pointing to 31337 chainId when it should be pointing to 13370. Even defining the envs like this, it's not working. What am I missing? I couldn't find any docs about this environment variables, I'd be glad if you could point me where I can find this. |
|
🤦 In was looking the wrong repository for this environment variables, I just found it |
I think the chain id 13370 is not supported yet, right? |
Have you tried to pass these variables to the docker container? It should work. CHAIN_ID 13370 ps: endpoint above is internal to our docker compose network |
It doesn't work, I still get the following error message: I used |
Glad you found it.
What container would that configuration go to the rollups-explorer-api? That will not work. We only work with what is described in the README in this repository. The CHAIN_IDS are to set the configuration. What could be done not sure if will work is CHAIN_IDS="31337"
RPC_URL_31337="http://anvil:8545"I mentioned about that I have a few questions:
cc: @endersonmaia , @tuler |
|
Since rollups-contracts-2.0.0-rc.17 started using canon and its chainid is 13370 |
|
@endersonmaia,
|
|
I updated the images, now I can see logs stating it's connected to the right chainId but still can't get the aplications being indexed nor inputs. |
|
Starting block is set to 22. I think it can be set to 1. Worth testing. |
|
defined the |
Could you confirm the ApplicationFactory e o InputBox address ? The addresses used in this branch were extracted from ApplicationFactory: 0x1d4CfBD2622d802A07CeB4C3401Bbb455c9dbdC3 @tuler, I checked out the latest rc.17 on npm and it is just a /out folder without information about the deployment address. So, I did not upgrade here. Any guidance as the deployment information changed would be very much appreciated if that is the case moving forward. |
rc.17 use cannon for deployment. To retrieve information you need to use cannon and execute the commands explained in the page above. Most likely that will be part of your project build pipeline. Install |
…all cannon available testnet deployments.
|
Now it's working. :) |
@endersonmaia also refresh the UI docker image. It was updated yesterday, now it included the new v2 contract addresses. important when sending a transaction e.g.
|
1d145e4
into
prerelease/rollups-v2-support-alpha
Summary
Code changes to support both rollup contracts v1 and v2 (currently available only for devnet and Sepolia).
Changes:
Applicationmodel to be queryable based on rollups version without the need to check the factory address (Depending on the query, it means no join).ApplicationCreatedandInputAddedevents.OwnershipTransferredwas updated to deal with both v1 and v2 events instead of adding a new one, as the topic hash for both contracts is the same. After looking at the generated code from ABI, I believe both handlers would be called sequentially, deeming a new handler unnecessary. PS: I assume it will be picked as the topic matches. There are at least three apps created on Sepolia, but none emitted the event.Events