feat: add jsonrpc prt tests by mpolitzer · Pull Request #733 · cartesi/rollups-node

mpolitzer · 2026-01-27T18:18:44Z

closes #682

Copilot

Pull request overview

This PR expands JSON-RPC test coverage for tournament-related (“prt”) methods and adjusts repository/query behavior to make list endpoints deterministic and align empty-list responses with existing “Application not found” semantics.

Changes:

Add extensive JSON-RPC tests for tournament/commitment/match/match-advanced endpoints.
Make list endpoints return RESOURCE_NOT_FOUND: Application not found when the result is empty and the application does not exist.
Stabilize ordering for pagination in Postgres queries (commitments and match advances).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
internal/repository/postgres/match_advanced.go	Changes ordering for `ListMatchAdvances` to sort by `OtherParent` (stabilizes pagination within a fixed epoch/tournament/id_hash).
internal/repository/postgres/commitment.go	Adds secondary ORDER BY on `Commitment` to make pagination deterministic when many rows share the same `EpochIndex`.
internal/jsonrpc/jsonrpc.go	Adds “application exists” checks for multiple list handlers; tweaks `GetMatchAdvanced` parent handling.
internal/jsonrpc/util_test.go	Adds helper result structs for JSON unmarshalling in tests.
internal/jsonrpc/jsonrpc_test.go	Adds large suite of tests for new/expanded tournament data methods.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/jsonrpc/jsonrpc_test.go

internal/jsonrpc/jsonrpc.go

internal/jsonrpc/util_test.go

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/jsonrpc/jsonrpc.go

internal/jsonrpc/jsonrpc_test.go

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-13T20:23:46Z

internal/jsonrpc/jsonrpc_test.go

+		method := getName(t.Name())
+
+		// failure: tournament address not hex encoded -> invalid param
+		t.Run("malformedApplicationParameter", func(t *testing.T) {


The test name "malformedApplicationParameter" is misleading because this test is actually checking for a malformed tournament address parameter (not application parameter). The application parameter is valid in this test. Consider renaming to "malformedAddressParameter" to accurately reflect what is being tested.

Suggested change

t.Run("malformedApplicationParameter", func(t *testing.T) {

t.Run("malformedAddressParameter", func(t *testing.T) {

Copilot · 2026-02-13T20:23:46Z

internal/jsonrpc/jsonrpc.go

 	}

-	if _, err := hex.DecodeString(params.Commitment); err != nil {
+	if _, err := hex.DecodeString(params.Commitment); (len(params.Commitment) == 0) || (err != nil) {


The error message will display "Invalid commitment hex: " when the commitment parameter is empty, because hex.DecodeString("") succeeds (returns nil error). Consider checking for empty string first and providing a more specific error message, or use a validation function similar to config.ToHashFromString which requires the 0x prefix and proper hex encoding.

Suggested change

if _, err := hex.DecodeString(params.Commitment); (len(params.Commitment) == 0) || (err != nil) {

if len(params.Commitment) == 0 {

writeRPCError(w, req.ID, JSONRPC_INVALID_PARAMS, "Commitment must not be empty", nil)

return

}

if _, err := hex.DecodeString(params.Commitment); err != nil {

Copilot · 2026-02-13T20:23:47Z

internal/jsonrpc/jsonrpc_test.go

+			assert.Equal(t, "Application not found", resp.Error.Message)
+		})
+
+		// success: no tournament in the database -> 0


The comment says "no tournament in the database" but this test is for cartesi_listMatches and checks for empty matches. Consider updating the comment to say "no match in the database" to accurately reflect what the test does.

Suggested change

// success: no tournament in the database -> 0

// success: no match in the database -> 0

Copilot · 2026-02-13T20:23:47Z

internal/jsonrpc/jsonrpc_test.go

+		// success: many match_advances
+		// create one tournament with many (match_advances) pairs.


The comment says "many match_advances" but this test is for cartesi_listCommitments and creates commitments. Consider updating the comment to say "many commitments" to accurately reflect what the test does.

Suggested change

// success: many match_advances

// create one tournament with many (match_advances) pairs.

// success: many commitments

// create one tournament with many commitments.

Copilot · 2026-02-13T20:23:47Z

internal/jsonrpc/jsonrpc_test.go

+	t.Run("cartesi_listMatchAdvances", func(t *testing.T) {
+		method := getName(t.Name())
+
+		// failure: no match in the database -> no application


The comment says "no match in the database" but this test is for cartesi_listMatchAdvances and checks for absent application. Consider updating the comment to say "no match advance in the database" to accurately reflect what the test does.

Suggested change

// failure: no match in the database -> no application

// failure: no match advance in the database -> no application

Copilot · 2026-02-13T20:23:47Z

internal/jsonrpc/jsonrpc_test.go

+		// success: many tournaments
+		// create one application with many (epoch, tournament) pairs.
+		// use their shared Index / EpochIndex to check pagination.


The comment says "many tournaments" but this test is for cartesi_listMatches and creates matches, not tournaments. Consider updating the comment to say "many matches" to accurately reflect what the test does.

Suggested change

// success: many tournaments

// create one application with many (epoch, tournament) pairs.

// use their shared Index / EpochIndex to check pagination.

// success: many matches

// create one application with many (epoch, match) pairs.

// use their shared indices to check pagination.

Copilot · 2026-02-13T20:23:47Z

internal/jsonrpc/jsonrpc_test.go

+	t.Run("cartesi_listCommitments", func(t *testing.T) {
+		method := getName(t.Name())
+
+		// failure: no match in the database -> no application


The comment says "no match in the database" but this test is for cartesi_listCommitments and checks for absent application. Consider updating the comment to say "no commitment in the database" to accurately reflect what the test does.

Suggested change

// failure: no match in the database -> no application

// failure: no application in the database

Copilot · 2026-02-13T20:23:48Z

internal/jsonrpc/jsonrpc_test.go

+			assert.Equal(t, "Application not found", resp.Error.Message)
+		})
+
+		// success: no tournament in the database -> 0


The comment says "no tournament in the database" but this test is for cartesi_listCommitments and checks for empty commitments. Consider updating the comment to say "no commitment in the database" to accurately reflect what the test does.

Suggested change

// success: no tournament in the database -> 0

// success: no commitment in the database -> 0

Copilot · 2026-02-13T20:23:48Z

internal/jsonrpc/jsonrpc_test.go

+			assert.Equal(t, "Application not found", resp.Error.Message)
+		})
+
+		// success: no tournament in the database -> 0


The comment says "no tournament in the database" but this test is for cartesi_listMatchAdvances and checks for empty match advances. Consider updating the comment to say "no match advance in the database" to accurately reflect what the test does.

Suggested change

// success: no tournament in the database -> 0

// success: no match advance in the database -> 0

mpolitzer requested review from renatomaia and vfusco January 27, 2026 18:18

mpolitzer self-assigned this Jan 27, 2026

mpolitzer added the #feat:tests Feature: tests label Jan 27, 2026

mpolitzer added this to Node Unit Jan 27, 2026

mpolitzer force-pushed the feature/add-jsonrpc-prt-tests branch from 5b26aa7 to 875aa23 Compare January 27, 2026 18:19

vfusco requested review from Copilot and removed request for renatomaia and vfusco February 11, 2026 12:35

Copilot started reviewing on behalf of vfusco February 11, 2026 12:35 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

mpolitzer force-pushed the feature/add-jsonrpc-prt-tests branch 2 times, most recently from 5442605 to e0b5bff Compare February 11, 2026 19:17

This was linked to issues Feb 12, 2026

Tests: JSON-RPC correctness, limit & security coverage, and OpenRPC schema compliance #682

Open

Add unit tests for new JSON-RPC methods (PRT dispute entities) #726

Open

mpolitzer moved this to 🏗 In progress in Node Unit Feb 12, 2026

vfusco requested a review from Copilot February 12, 2026 18:23

Copilot started reviewing on behalf of vfusco February 12, 2026 18:24 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

mpolitzer force-pushed the feature/add-jsonrpc-prt-tests branch 2 times, most recently from a13fa56 to 290a589 Compare February 12, 2026 19:12

feat: add jsonrpc prt tests

fc5f9a4

mpolitzer force-pushed the feature/add-jsonrpc-prt-tests branch from 290a589 to fc5f9a4 Compare February 13, 2026 13:24

vfusco requested a review from Copilot February 13, 2026 20:18

Copilot started reviewing on behalf of vfusco February 13, 2026 20:19 View session

Copilot AI reviewed Feb 13, 2026

View reviewed changes

vfusco approved these changes Feb 13, 2026

View reviewed changes

	t.Run("malformedApplicationParameter", func(t *testing.T) {
	t.Run("malformedAddressParameter", func(t *testing.T) {

	// success: no tournament in the database -> 0
	// success: no match in the database -> 0

		// success: many match_advances
		// create one tournament with many (match_advances) pairs.

	// failure: no match in the database -> no application
	// failure: no match advance in the database -> no application

	// failure: no match in the database -> no application
	// failure: no application in the database

	// success: no tournament in the database -> 0
	// success: no commitment in the database -> 0

	// success: no tournament in the database -> 0
	// success: no match advance in the database -> 0

Conversation

mpolitzer commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mpolitzer commented Jan 27, 2026 •

edited

Loading