Open
Conversation
0e17280 to
4d26ede
Compare
ac260d9 to
9cd1f93
Compare
cf100ec to
d51155e
Compare
4a06a4c to
29e2b75
Compare
29e2b75 to
a638c09
Compare
1b9266e to
d333721
Compare
73be453 to
b326bdb
Compare
and set DOCKER_API_VERSION env to 1.44.0 for client version Signed-off-by: Devanshu <devanshu.d@broadcom.com>
Signed-off-by: Devanshu <devanshu.d@broadcom.com>
Signed-off-by: Devanshu <devanshu.d@broadcom.com>
b326bdb to
fa76562
Compare
Signed-off-by: Devanshu <devanshu.d@broadcom.com>
Signed-off-by: Devanshu <devanshu.d@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR bumps the Docker API version requirements and updates associated dependencies to support the newer Docker engine (v28.0.4), which requires a minimum Docker API version of 1.44.0.
Changes:
- Bump Go to 1.25.7 and update
carvel.dev/imgpkgto v0.47.2 andcarvel.dev/vendirto v0.45.2 - Bump Bazel from 4.2.0 to 6.4.0 and update its associated rules in the WORKSPACE file
- Add
DOCKER_API_VERSION=1.44environment variable to test scripts and CI workflow, and fix parallel build interference in pack/bazel tests
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates Go version and carvel dependency versions |
| go.sum | Updates checksums for new carvel dependency versions |
| vendor/modules.txt | Reflects updated vendor module versions and Go version |
| hack/Dockerfile.dev | Updates base Go image and Bazel binary version |
| hack/test-e2e.sh | Updates Bazel version check to 6.4.0 |
| hack/test-all-minikube-local-registry.sh | Adds DOCKER_API_VERSION=1.44 env var |
| hack/test-all-locally.sh | Adds DOCKER_API_VERSION=1.44 env var to docker run |
| .github/workflows/test-gh.yml | Adds DOCKER_API_VERSION=1.44, a docker version check step, and relaxes minikube's internal Docker API requirement |
| test/e2e/build_pack_test.go | Fixes parallel build interference by using a separate asset directory |
| test/e2e/build_bazel_test.go | Fixes parallel build interference by using a separate asset directory |
| test/e2e/assets/simple-app/WORKSPACE | Bumps Bazel rules and adds rules_go and bazel_gazelle dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Devanshu <devanshu.d@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump golang to 1.25.7
Bump carvel imgpkg to v0.47.2 and vendir to v0.45.2
The default docker engine version has been bumped to 28.0.4 which supports min docker version as 1.44.0
Some of the kbld tests wrt buildx, ko and pack cli wer using old cli versions.
This has been fixed by specifying a min docker api versin for client and server (in minikube)
Also it necessitates the bump for bazel and its associated rules binary version in WORKSPACE