check for rand.Int error added via latest PR#224
Open
cppforlife wants to merge 1 commit intodevelopfrom
Open
Conversation
plus minor stylistic tweaks Signed-off-by: Dmitriy Kalinin <dkalinin@vmware.com>
Member
joaopapereira
left a comment
joaopapereira
left a comment
There was a problem hiding this comment.
The PR looks good I just have a minor comment that maybe we can improve.
| func localCryptoShuffle(n int, swap func(i, j int)) { | ||
| func (*PasswordReconciler) localCryptoShuffle(n int, swap func(i, j int)) error { | ||
| if n < 0 { | ||
| panic("invalid argument to Shuffle") |
Member
There was a problem hiding this comment.
This should not panic the generator unless it is an internal inconsistency error. This looks like invalid input from the spec itself, since we now have an output error maybe we can return it instead.
|
hey @joaopapereira / @cppforlife, just checking in to see if we can push this PR through? Any blockers or discussions needed? |
|
Hey @cppforlife / @joaopapereira . This one has been sitting for a long time, shall we close it out? Or can we get this over the line? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.